From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Theodore Ts'o" <tytso@MIT.EDU>
Cc: Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH, RFC] ext3: move headers out of include/linux
Date: Thu, 1 May 2008 11:39:38 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0805011134520.5994@woody.linux-foundation.org> (raw)
In-Reply-To: <E1JrZxd-0004c8-7E@closure.thunk.org>
On Thu, 1 May 2008, Theodore Ts'o wrote:
>
> fs/ext3/acl.c | 4 +-
> fs/ext3/balloc.c | 5 +-
> fs/ext3/bitmap.c | 2 +-
> fs/ext3/dir.c | 3 +-
> fs/ext3/ext3.h | 897 ++++++++++++++++++++++++++++++++++++++++++++
> fs/ext3/ext3_i.h | 147 ++++++++
> fs/ext3/ext3_jbd.c | 7 +-
> fs/ext3/ext3_jbd.h | 225 +++++++++++
> fs/ext3/ext3_sb.h | 86 +++++
> fs/ext3/file.c | 5 +-
> fs/ext3/fsync.c | 5 +-
> fs/ext3/hash.c | 3 +-
> fs/ext3/ialloc.c | 5 +-
> fs/ext3/inode.c | 4 +-
> fs/ext3/ioctl.c | 5 +-
> fs/ext3/namei.c | 5 +-
> fs/ext3/resize.c | 6 +-
> fs/ext3/super.c | 5 +-
> fs/ext3/symlink.c | 3 +-
> fs/ext3/xattr.c | 4 +-
> fs/ext3/xattr_security.c | 4 +-
> fs/ext3/xattr_trusted.c | 4 +-
> fs/ext3/xattr_user.c | 5 +-
> include/linux/ext3_fs.h | 896 -------------------------------------------
> include/linux/ext3_fs_i.h | 147 --------
> include/linux/ext3_fs_sb.h | 86 -----
> include/linux/ext3_jbd.h | 226 -----------
I'd suggest not sending out patches like this.
If the patch is largely a rename one, and sent out for review, just use
"git diff -M -p --stat --summary", because it's going to be a *lot* more
reviewable that way.
Yeah, it means that people need git to apply it, but by now we can
probably take that for granted - and more importantly, even if they don't
have git installed: when you send out of RFC, aren't you looking for
commentary more than people to apply and test it?
And then the patch saying that it's a rename (with perhaps changes to the
guard #ifdef thing) would be a lot more clear. Nobody is going to read a
patch that is 2800 lines of mostly create/delete with presumably almost no
actual changes?
Linus
next prev parent reply other threads:[~2008-05-01 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 14:40 Theodore Ts'o
2008-05-01 15:30 ` Christoph Hellwig
2008-05-03 21:16 ` Olaf Hering
2008-05-01 18:39 ` Linus Torvalds [this message]
2008-05-02 13:48 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805011134520.5994@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®