From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935843AbYEBWS3 (ORCPT ); Fri, 2 May 2008 18:18:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758722AbYEBWSW (ORCPT ); Fri, 2 May 2008 18:18:22 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:39535 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756039AbYEBWSV (ORCPT ); Fri, 2 May 2008 18:18:21 -0400 Date: Fri, 2 May 2008 15:17:00 -0700 (PDT) From: Linus Torvalds To: "H. Peter Anvin" cc: "Carlos R. Mafra" , Linux Kernel Mailing List Subject: Re: [PATCH] kernel/time.c: Silence gcc warning 'integer constant to large for long type' In-Reply-To: <481B888F.3070302@zytor.com> Message-ID: References: <200805021858.m42Iw4Lj025952@tazenda.hos.anvin.org> <481B888F.3070302@zytor.com> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 May 2008, H. Peter Anvin wrote: > > That's more or less what my other patchset does. It's a bit more complex > (because it gets the suffixes via macros, to get the right suffixes), but most > of it is pure cleanup of the way we handle integers in architecture includes: > > git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-inttypes.git This is *still* wrong. That C type prefix should be at the *define*, not the use of those macros. The thing is, if C code needs to do U64_C(HZ_TO_USEC_MUL32) to use the macro HZ_TO_USEC_MUL32, then that is a *bug* in the macro. That kind of stuff should not be visible to users of plain constants! Linus