From: Linus Torvalds <torvalds@linux-foundation.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Austin Clements <amdragon+kernelbugzilla@mit.edu>,
Ingo Molnar <mingo@elte.hu>, john stultz <johnstul@us.ibm.com>,
Michael Kerrisk <mtk.manpages@googlemail.com>,
Roland McGrath <roland@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] posix timers: sigqueue_free: don't free sigqueue if it is queued
Date: Sat, 3 May 2008 10:51:47 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0805031039430.5994@woody.linux-foundation.org> (raw)
In-Reply-To: <20080503173553.GA8106@tv-sign.ru>
On Sat, 3 May 2008, Oleg Nesterov wrote:
>
> Note: I am not sure we shouldn't do the opposite, free sigqueue + cancel the
> pending signal, but this needs some ugly changes. Perhaps we should reconsider
> this change later. See also http://bugzilla.kernel.org/show_bug.cgi?id=10460
You know what, I think there might be an even simple solution.
How about just setting a bit saying it is canceled - and nothing more.
Then, the dequeue logic can be just taught to ignore those things.
Doesn't that sound like the simple way to cancel signals? Make
collect_signal() just do a "return 0" if the signal has been flushed..
Linus
next prev parent reply other threads:[~2008-05-03 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 17:35 Oleg Nesterov
2008-05-03 17:43 ` Oleg Nesterov
2008-05-03 17:51 ` Linus Torvalds [this message]
2008-05-03 19:19 ` Oleg Nesterov
2008-05-17 15:13 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805031039430.5994@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=amdragon+kernelbugzilla@mit.edu \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtk.manpages@googlemail.com \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®