From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760938AbYEFPLD (ORCPT ); Tue, 6 May 2008 11:11:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754672AbYEFPKy (ORCPT ); Tue, 6 May 2008 11:10:54 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:55195 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbYEFPKx (ORCPT ); Tue, 6 May 2008 11:10:53 -0400 Date: Tue, 6 May 2008 08:09:35 -0700 (PDT) From: Linus Torvalds To: Ingo Molnar cc: Hugh Dickins , Jeff Chua , Linux Kernel Mailing List , Thomas Gleixner , "H. Peter Anvin" , Gabriel C , Jeremy Fitzhardinge Subject: Re: Linux 2.6.26-rc1 - pgtable_32.c:178 pmd_bad In-Reply-To: <20080506150432.GA31075@elte.hu> Message-ID: References: <20080506124946.GA2146@elte.hu> <20080506150432.GA31075@elte.hu> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 May 2008, Ingo Molnar wrote: > > hm, the main objection was about whether to turn PAGE_SIZE from unsigned > into signed though - and that we didnt do. No it wasn't. The main objection was that you SHOULD NOT USE PAGE_SIZE_MASK AT ALL! You should have used a pagetable-specific macro, becuse PAGE_MASK is simply fundamentally WRONG, and has absolutely nothing to do with the PFN bits, whether sign-extended or not! The fact is, the page frane number bits are *not* ~PAGE_MASK or anything like that. They share only the low bits - not the high bits. Linus