Re: [PATCH] clocksource: shift helper

[Thomas Gleixner <tglx@linutronix.de>]

On Tue, 6 May 2008, Daniel Walker wrote:
> On Tue, 2008-05-06 at 22:53 +0200, Thomas Gleixner wrote:
> > 
> > And your description led me to the assumption that the code was pulled
> > from the MIPS git tree and not from the MIPS architecture code in
> > mainline. Everyone else I talked to was having the same impression.
> > 
> > I was wrong, but can you understand that your sloppy wording "pulled
> > from the MIPS tree" along with the fact that you just copied code
> > instead of moving it into the generic space and cleanup the MIPS code
> > where it is duplicated from is causing such a misunderstanding ?
> 
> You could have asked me if it was mainline or not. I can see how words
> could be misunderstood .

You - the patch submitter - have to provide useful information to
those who review the patches and not the reviewers are supposed to
decode your sloppy commit log.

"... which I pulled from the MIPS tree"

Why should I assume that this is from mainline ?

> > I'm fine with the change itself, but it needs to move the code out of
> > MIPS in the first place and not just duplicating code for no good
> > reason.
> 
> I can work with Atsushi, but I still think the generic version should be
> merged. We at least would need it in order to modify the mips code.

You can think what you want, it's not the way it works.

You duplicate code, so the first thing to do is to replace the code
which you copied and make sure it is still fully functional. Then you
can add a second user to make the point that the generic code move is
actually useful. btw, pmtimer is the worst example for a good use case
as everything there is constant so we can do it at compile time.

Thanks,
	tglx