From: Thomas Gleixner <tglx@linutronix.de>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Shen Feng <shen@cn.fujitsu.com>,
hpa@zytor.com, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH] x86: remove printk compiling warning
Date: Thu, 8 May 2008 16:36:33 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.1.10.0805081635270.3318@apollo.tec.linutronix.de> (raw)
In-Reply-To: <482167DF.4020200@cn.fujitsu.com>
On Wed, 7 May 2008, Li Zefan wrote:
> CC: Randy Dunlap <rdunlap@xenotime.net>
>
> Shen Feng wrote:
> > Since size is unsigned long, the format string is changed
> > from zd to lu.
> >
> > Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
> > ---
> > arch/x86/kernel/setup.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> > index cc6f5eb..c0c68c1 100644
> > --- a/arch/x86/kernel/setup.c
> > +++ b/arch/x86/kernel/setup.c
> > @@ -95,7 +95,7 @@ void __init setup_per_cpu_areas(void)
> >
> > /* Copy section for each CPU (we discard the original) */
> > size = PERCPU_ENOUGH_ROOM;
> > - printk(KERN_INFO "PERCPU: Allocating %zd bytes of per cpu data\n",
> > + printk(KERN_INFO "PERCPU: Allocating %lu bytes of per cpu data\n",
> > size);
> >
> > for_each_possible_cpu(i) {
>
> Let me figure out this.
>
> Commit 0fc5035fc66d26776bebd45c508a9bce3611f388 in linux-next changed
> 'size' from unsigned long to ssize_t, causing a compile warning, and
> then Randy posted a patch to fix it:
> http://marc.info/?l=linux-kernel&m=120958902125650&w=2
>
> But this patch was wrongly merged into mainline, causing the compile warning
> you described here.
>
> So we should revert Randy's patch and re-apply it to linux-next ?
Yes, this came via Andrew and we did not notice that it was for
linux-next.
Thanks,
tglx
prev parent reply other threads:[~2008-05-08 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 8:05 Shen Feng
2008-05-07 8:27 ` Li Zefan
2008-05-07 15:39 ` Randy Dunlap
2008-05-08 14:36 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805081635270.3318@apollo.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=rdunlap@xenotime.net \
--cc=shen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®