From: Linus Torvalds <torvalds@linux-foundation.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, Jon Masters <jonathan@jonmasters.org>
Subject: Re: [PATCH 3/3] module: don't ignore vermagic string if module doesn't have modversions
Date: Fri, 9 May 2008 07:44:34 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0805090739240.3142@woody.linux-foundation.org> (raw)
In-Reply-To: <200805091625.28705.rusty@rustcorp.com.au>
On Fri, 9 May 2008, Rusty Russell wrote:
>
> We should only ignore the start of the vermagic string if the module
> actually *has* crcs to check. Rather than (say) having an
> entertaining hissy fit and creating a config option to work around the
> buggy code.
Btw, this makes the two vesions of "same_magic()" be basically the same
(since without MODVERSIONS, has_crcs *should* always be zero). Maybe we
should make it just one version, to simplify logic?
Linus
next prev parent reply other threads:[~2008-05-09 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 6:23 [PATCH 1/3] module: put modversions in vermagic Rusty Russell
2008-05-09 6:24 ` [PATCH 2/3] module: be more picky about allowing missing module versions Rusty Russell
2008-05-09 6:25 ` [PATCH 3/3] module: don't ignore vermagic string if module doesn't have modversions Rusty Russell
2008-05-09 14:44 ` Linus Torvalds [this message]
2008-05-11 0:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805090739240.3142@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=jonathan@jonmasters.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome