From: Linus Torvalds <torvalds@linux-foundation.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: ajones@riverbed.com, a.p.zijlstra@chello.nl, mszeredi@suse.cz,
akpm@linux-foundation.org, kay.sievers@vrfy.org, greg@kroah.com,
trond.myklebust@fys.uio.no, linux-kernel@vger.kernel.org
Subject: Re: [BUG] mm: bdi: export BDI attributes in sysfs
Date: Thu, 15 May 2008 12:54:57 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0805151247010.3019@woody.linux-foundation.org> (raw)
In-Reply-To: <E1Jwj7G-0007Zs-GB@pomaz-ex.szeredi.hu>
On Thu, 15 May 2008, Miklos Szeredi wrote:
>
> Actually nothing should need protection. The only problem AFAICS is
> that the device_create()/dev_set_drvdata() interface is racy: somebody
> can come in after the device has been created but before drvdata has
> been set, and then we are in trouble.
Well, I'm not sure that the locking should be at that level. Maybe the
locking *should* be in the driver that does this. It may need to do other
setup too, after all.
Of course, doing a device_create_drvdata() thing might be the right
solution, at least part of the time. Greg?
Linus
next prev parent reply other threads:[~2008-05-15 19:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080513190435.GG23649@ajones-laptop.nbttech.com>
2008-05-14 14:40 ` Arthur Jones
2008-05-15 18:53 ` Miklos Szeredi
2008-05-15 19:18 ` Linus Torvalds
2008-05-15 19:27 ` Miklos Szeredi
2008-05-15 19:54 ` Linus Torvalds [this message]
2008-05-15 20:40 ` Greg KH
2008-05-15 21:02 ` Greg KH
2008-05-15 22:05 ` Arthur Jones
2008-05-15 23:20 ` Greg KH
2008-05-16 4:59 ` Greg KH
2008-05-15 20:37 ` Greg KH
2008-05-15 20:40 ` Greg KH
2008-05-15 20:44 ` Arthur Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805151247010.3019@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=ajones@riverbed.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@suse.cz \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®