From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762145AbYESRc6 (ORCPT ); Mon, 19 May 2008 13:32:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754891AbYESRcs (ORCPT ); Mon, 19 May 2008 13:32:48 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:38543 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752322AbYESRcr (ORCPT ); Mon, 19 May 2008 13:32:47 -0400 Date: Mon, 19 May 2008 10:27:17 -0700 (PDT) From: Linus Torvalds To: Boaz Harrosh cc: Alan Stern , Maciej Rutecki , Linux Kernel Mailing List , USB list , USB Storage list , SCSI development list Subject: Re: [Re: Linux 2.6.26-rc2] Write protect on on In-Reply-To: <4831B2E2.8030700@panasas.com> Message-ID: References: <4831A60A.5010308@panasas.com> <4831B2E2.8030700@panasas.com> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 May 2008, Boaz Harrosh wrote: > > Sure, inspecting other places that emulate MODE_SENSE, (And inspecting the scsi > spec) all zeros is a very good scsi response. Alan do you want to send a fix for all > places that initiate a MODE_SENSE command, specifically at > scsi_scan.c::scsi_unlock_floptical() ? (Some other places do) I was actualyl more thinking that the safest thing to do would be to just pre-clear the sense buffer. Then, if some driver doesn't fill it correctly, big deal.. It's not like pre-clearing the bugger is a performance issue. Linus