mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] SERIAL:  Simplify code using ARRAY_SIZE() macro.
Date: Sun, 25 May 2008 13:09:21 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0805251308420.25842@localhost.localdomain> (raw)
In-Reply-To: <483998EC.5080805@gmail.com>

On Sun, 25 May 2008, Jiri Slaby wrote:

> On 05/25/2008 01:37 PM, Robert P. J. Day wrote:
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> >  drivers/serial/68328serial.c |    6 +++---
> >  drivers/serial/mcfserial.c   |    5 ++---
> >  2 files changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
> > index bbf5bc5..71c56c1 100644
> > --- a/drivers/serial/68328serial.c
> > +++ b/drivers/serial/68328serial.c
> [...]
> > @@ -1413,10 +1413,10 @@ static void m68328_set_baud(void)
> >  	USTCNT = ustcnt & ~USTCNT_TXEN;
> >
> >  again:
> > -	for (i = 0; i < sizeof(baud_table) / sizeof(baud_table[0]); i++)
> > +	for (i = 0; i < BAUD_TABLE_SIZE); i++)
>
> typo? does this compile?

oh, gack, my bad.  it compiled, then i figured i'd innocently fix up
some white space and pooched it.  sorry.  will resubmit.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

  reply	other threads:[~2008-05-25 17:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-25 11:37 Robert P. J. Day
2008-05-25 16:50 ` Jiri Slaby
2008-05-25 17:09   ` Robert P. J. Day [this message]
2008-05-25 18:41     ` Joe Perches
2008-05-26  7:38       ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0805251308420.25842@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=akpm@osdl.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®