mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Miller <davem@davemloft.net>,
	linux-arch@vger.kernel.org, scottwood@freescale.com,
	linuxppc-dev@ozlabs.org, alan@lxorguk.ukuu.org.uk,
	linux-kernel@vger.kernel.org, tpiepho@freescale.com
Subject: Re: MMIO and gcc re-ordering issue
Date: Tue, 27 May 2008 09:47:13 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0805270943100.2958@woody.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0805270833060.2958@woody.linux-foundation.org>



On Tue, 27 May 2008, Linus Torvalds wrote:
> 
> Expecting people to fix up all drivers is simply not going to happen. And 
> serializing things shouldn't be *that* expensive. People who cannot take 
> the expense can continue to use the magic __raw_writel() etc stuff.

Of course, for non-x86, you kind of have to expect drivers to be 
well-behaved, so non-x86 can probably avoid this simply because there are 
less relevant drivers involved.

Here's a UNTESTED patch for x86 that may or may not compile and work, and 
which serializes (on a compiler level) the IO accesses against regular 
memory accesses.

__read[bwlq]()/__write[bwlq]() are not serialized with a :"memory" 
barrier, although since they still use "asm volatile" I suspect that i 
practice they are probably serial too. Did not look very closely at any 
generated code (only did a trivial test to see that the code looks 
*roughly* correct).

		Linus

---
 include/asm-x86/io.h    |   56 +++++++++++++++++++++++++++++++++++++
 include/asm-x86/io_32.h |   49 --------------------------------
 include/asm-x86/io_64.h |   71 -----------------------------------------------
 3 files changed, 56 insertions(+), 120 deletions(-)

diff --git a/include/asm-x86/io.h b/include/asm-x86/io.h
index d5b11f6..8e9eca9 100644
--- a/include/asm-x86/io.h
+++ b/include/asm-x86/io.h
@@ -3,6 +3,62 @@
 
 #define ARCH_HAS_IOREMAP_WC
 
+#include <linux/compiler.h>
+
+#define build_mmio_read(name, size, type, reg, barrier) \
+static inline type name(const volatile void __iomem *addr) \
+{ type ret; asm volatile("mov" size " %1,%0":"=" reg (ret) \
+:"m" (*(volatile type __force *)addr) barrier); return ret; }
+
+#define build_mmio_write(name, size, type, reg, barrier) \
+static inline void name(type val, volatile void __iomem *addr) \
+{ asm volatile("mov" size " %0,%1": :reg (val), \
+"m" (*(volatile type __force *)addr) barrier); }
+
+build_mmio_read(readb, "b", unsigned char, "q", :"memory")
+build_mmio_read(readw, "w", unsigned short, "r", :"memory")
+build_mmio_read(readl, "l", unsigned int, "r", :"memory")
+
+build_mmio_read(__readb, "b", unsigned char, "q", )
+build_mmio_read(__readw, "w", unsigned short, "r", )
+build_mmio_read(__readl, "l", unsigned int, "r", )
+
+build_mmio_write(writeb, "b", unsigned char, "q", :"memory")
+build_mmio_write(writew, "w", unsigned short, "r", :"memory")
+build_mmio_write(writel, "l", unsigned int, "r", :"memory")
+
+build_mmio_write(__writeb, "b", unsigned char, "q", )
+build_mmio_write(__writew, "w", unsigned short, "r", )
+build_mmio_write(__writel, "l", unsigned int, "r", )
+
+#define readb_relaxed(a) __readb(a)
+#define readw_relaxed(a) __readw(a)
+#define readl_relaxed(a) __readl(a)
+#define __raw_readb __readb
+#define __raw_readw __readw
+#define __raw_readl __readl
+
+#define __raw_writeb __writeb
+#define __raw_writew __writew
+#define __raw_writel __writel
+
+#define mmiowb() barrier()
+
+#ifdef CONFIG_X86_64
+build_mmio_read(readq, "q", unsigned long, "r", :"memory")
+build_mmio_read(__readq, "q", unsigned long, "r", )
+build_mmio_write(writeq, "q", unsigned long, "r", :"memory")
+build_mmio_write(__writeq, "q", unsigned long, "r", )
+
+#define readq_relaxed(a) __readq(a)
+#define __raw_readq __readq
+#define __raw_writeq writeq
+
+/* Let people know we have them */
+#define readq readq
+#define writeq writeq
+#endif
+
 #ifdef CONFIG_X86_32
 # include "io_32.h"
 #else
diff --git a/include/asm-x86/io_32.h b/include/asm-x86/io_32.h
index 049e81e..d71be8d 100644
--- a/include/asm-x86/io_32.h
+++ b/include/asm-x86/io_32.h
@@ -149,55 +149,6 @@ extern void __iomem *fix_ioremap(unsigned idx, unsigned long phys);
 #define virt_to_bus virt_to_phys
 #define bus_to_virt phys_to_virt
 
-/*
- * readX/writeX() are used to access memory mapped devices. On some
- * architectures the memory mapped IO stuff needs to be accessed
- * differently. On the x86 architecture, we just read/write the
- * memory location directly.
- */
-
-static inline unsigned char readb(const volatile void __iomem *addr)
-{
-	return *(volatile unsigned char __force *)addr;
-}
-
-static inline unsigned short readw(const volatile void __iomem *addr)
-{
-	return *(volatile unsigned short __force *)addr;
-}
-
-static inline unsigned int readl(const volatile void __iomem *addr)
-{
-	return *(volatile unsigned int __force *) addr;
-}
-
-#define readb_relaxed(addr) readb(addr)
-#define readw_relaxed(addr) readw(addr)
-#define readl_relaxed(addr) readl(addr)
-#define __raw_readb readb
-#define __raw_readw readw
-#define __raw_readl readl
-
-static inline void writeb(unsigned char b, volatile void __iomem *addr)
-{
-	*(volatile unsigned char __force *)addr = b;
-}
-
-static inline void writew(unsigned short b, volatile void __iomem *addr)
-{
-	*(volatile unsigned short __force *)addr = b;
-}
-
-static inline void writel(unsigned int b, volatile void __iomem *addr)
-{
-	*(volatile unsigned int __force *)addr = b;
-}
-#define __raw_writeb writeb
-#define __raw_writew writew
-#define __raw_writel writel
-
-#define mmiowb()
-
 static inline void
 memset_io(volatile void __iomem *addr, unsigned char val, int count)
 {
diff --git a/include/asm-x86/io_64.h b/include/asm-x86/io_64.h
index 0930bed..ddd8058 100644
--- a/include/asm-x86/io_64.h
+++ b/include/asm-x86/io_64.h
@@ -204,77 +204,6 @@ extern void __iomem *fix_ioremap(unsigned idx, unsigned long phys);
 #define virt_to_bus virt_to_phys
 #define bus_to_virt phys_to_virt
 
-/*
- * readX/writeX() are used to access memory mapped devices. On some
- * architectures the memory mapped IO stuff needs to be accessed
- * differently. On the x86 architecture, we just read/write the
- * memory location directly.
- */
-
-static inline __u8 __readb(const volatile void __iomem *addr)
-{
-	return *(__force volatile __u8 *)addr;
-}
-
-static inline __u16 __readw(const volatile void __iomem *addr)
-{
-	return *(__force volatile __u16 *)addr;
-}
-
-static __always_inline __u32 __readl(const volatile void __iomem *addr)
-{
-	return *(__force volatile __u32 *)addr;
-}
-
-static inline __u64 __readq(const volatile void __iomem *addr)
-{
-	return *(__force volatile __u64 *)addr;
-}
-
-#define readb(x) __readb(x)
-#define readw(x) __readw(x)
-#define readl(x) __readl(x)
-#define readq(x) __readq(x)
-#define readb_relaxed(a) readb(a)
-#define readw_relaxed(a) readw(a)
-#define readl_relaxed(a) readl(a)
-#define readq_relaxed(a) readq(a)
-#define __raw_readb readb
-#define __raw_readw readw
-#define __raw_readl readl
-#define __raw_readq readq
-
-#define mmiowb()
-
-static inline void __writel(__u32 b, volatile void __iomem *addr)
-{
-	*(__force volatile __u32 *)addr = b;
-}
-
-static inline void __writeq(__u64 b, volatile void __iomem *addr)
-{
-	*(__force volatile __u64 *)addr = b;
-}
-
-static inline void __writeb(__u8 b, volatile void __iomem *addr)
-{
-	*(__force volatile __u8 *)addr = b;
-}
-
-static inline void __writew(__u16 b, volatile void __iomem *addr)
-{
-	*(__force volatile __u16 *)addr = b;
-}
-
-#define writeq(val, addr) __writeq((val), (addr))
-#define writel(val, addr) __writel((val), (addr))
-#define writew(val, addr) __writew((val), (addr))
-#define writeb(val, addr) __writeb((val), (addr))
-#define __raw_writeb writeb
-#define __raw_writew writew
-#define __raw_writel writel
-#define __raw_writeq writeq
-
 void __memcpy_fromio(void *, unsigned long, unsigned);
 void __memcpy_toio(unsigned long, const void *, unsigned);
 

  reply	other threads:[~2008-05-27 16:47 UTC|newest]

Thread overview: 159+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20 20:40 [PATCH] [POWERPC] Improve (in|out)_beXX() asm code Trent Piepho
2008-05-20 21:16 ` Benjamin Herrenschmidt
2008-05-20 21:38   ` Scott Wood
2008-05-20 22:02     ` Benjamin Herrenschmidt
2008-05-20 22:21       ` Trent Piepho
2008-05-20 22:15     ` Alan Cox
2008-05-20 22:35       ` Scott Wood
2008-05-20 22:39         ` David Miller
2008-05-20 22:43           ` Scott Wood
2008-05-20 22:53             ` David Miller
2008-05-23  4:24               ` Benjamin Herrenschmidt
2008-05-22 22:56                 ` Trent Piepho
2008-05-23 12:36                   ` MMIO and gcc re-ordering (Was: [PATCH] [POWERPC] Improve (in|out)_beXX() asm code) Benjamin Herrenschmidt
2008-05-23 12:50                     ` Benjamin Herrenschmidt
2008-05-23 21:14                       ` Scott Wood
2008-05-23 22:47                         ` Benjamin Herrenschmidt
2008-05-27  1:33                   ` MMIO and gcc re-ordering issue Benjamin Herrenschmidt
2008-05-27  1:40                     ` David Miller
2008-05-27  2:15                       ` Benjamin Herrenschmidt
2008-05-27  2:28                         ` David Miller
2008-05-27  3:39                           ` Benjamin Herrenschmidt
2008-05-27 15:35                             ` Linus Torvalds
2008-05-27 16:47                               ` Linus Torvalds [this message]
2008-05-27 17:31                                 ` Linus Torvalds
2008-06-02 10:36                                   ` Ingo Molnar
2008-06-02 21:53                                     ` Benjamin Herrenschmidt
2008-05-27 21:12                                 ` Benjamin Herrenschmidt
2008-05-27 18:23                               ` Trent Piepho
2008-05-27 18:33                                 ` Scott Wood
2008-05-27 21:10                               ` Benjamin Herrenschmidt
2008-05-27 21:30                                 ` Linus Torvalds
2008-05-27 21:38                                   ` Alan Cox
2008-05-27 21:53                                     ` Matthew Wilcox
2008-05-27 21:46                                       ` Alan Cox
2008-05-27 22:02                                       ` Linus Torvalds
2008-05-27 21:59                                     ` Linus Torvalds
2008-05-27 21:38                                   ` Benjamin Herrenschmidt
2008-05-27 21:42                                     ` Matthew Wilcox
2008-05-27 22:17                                       ` Benjamin Herrenschmidt
2008-05-28  8:36                                         ` Haavard Skinnemoen
2008-05-29 11:05                                           ` Pantelis Antoniou
2008-05-30  1:13                                           ` Benjamin Herrenschmidt
2008-05-30  6:07                                             ` Haavard Skinnemoen
2008-05-30  7:24                                               ` Benjamin Herrenschmidt
2008-05-30  8:27                                                 ` Haavard Skinnemoen
2008-05-30  9:22                                                   ` Geert Uytterhoeven
2008-06-02  8:11                                                     ` Haavard Skinnemoen
2008-06-02 15:48                                                       ` Scott Wood
2008-06-03  7:46                                                         ` Haavard Skinnemoen
2008-06-04 15:31                                                       ` Linus Torvalds
2008-05-27 21:55                                     ` Linus Torvalds
2008-05-27 22:19                                       ` Benjamin Herrenschmidt
2008-05-29  7:10                                         ` Arnd Bergmann
2008-05-29 10:46                                           ` Alan Cox
2008-06-02  7:24                                       ` Russell King
2008-06-03  4:16                                         ` Nick Piggin
2008-06-03  4:32                                           ` Benjamin Herrenschmidt
2008-06-03  6:11                                             ` Nick Piggin
2008-06-03  6:48                                               ` Benjamin Herrenschmidt
2008-06-03  6:53                                               ` Paul Mackerras
2008-06-03  7:18                                                 ` Nick Piggin
2008-06-03 14:47                                           ` Linus Torvalds
2008-06-03 18:47                                             ` Trent Piepho
2008-06-03 18:55                                               ` Matthew Wilcox
2008-06-03 19:57                                                 ` Trent Piepho
2008-06-03 21:35                                                   ` Matthew Wilcox
2008-06-03 21:58                                                     ` Trent Piepho
2008-06-04  2:00                                                       ` Nick Piggin
2008-06-03 19:07                                               ` Linus Torvalds
2008-06-04  2:05                                                 ` Nick Piggin
2008-06-04  2:46                                                   ` Linus Torvalds
2008-06-04 11:47                                                     ` Alan Cox
2008-06-10  6:56                                                 ` Nick Piggin
2008-06-10 17:41                                                   ` Jesse Barnes
2008-06-10 18:10                                                     ` James Bottomley
2008-06-10 19:05                                                       ` Roland Dreier
2008-06-10 19:19                                                         ` Jesse Barnes
2008-06-11  3:29                                                           ` Nick Piggin
2008-06-11  3:40                                                             ` Benjamin Herrenschmidt
2008-06-11  4:06                                                               ` Nick Piggin
2008-06-11 16:07                                                             ` Jesse Barnes
2008-06-12 11:27                                                               ` Nick Piggin
2008-06-11  4:18                                                   ` Paul Mackerras
2008-06-11  5:00                                                     ` Nick Piggin
2008-06-11  5:13                                                       ` Paul Mackerras
2008-06-11  5:35                                                         ` Nick Piggin
2008-06-11  6:02                                                           ` Nick Piggin
2008-06-12 12:14                                                           ` Paul Mackerras
2008-06-12 13:08                                                             ` Nick Piggin
2008-06-11 14:46                                                       ` Linus Torvalds
2008-06-11  5:20                                                   ` Paul Mackerras
2008-06-04  2:19                                             ` Nick Piggin
2008-06-03 19:43                                           ` Trent Piepho
2008-06-03 21:33                                             ` Matthew Wilcox
2008-06-03 21:44                                               ` Trent Piepho
2008-06-04  2:25                                                 ` Nick Piggin
2008-06-04  6:39                                                   ` Trent Piepho
2008-06-03 22:26                                             ` Benjamin Herrenschmidt
2008-05-27  3:42                           ` Arjan van de Ven
2008-05-27  4:08                             ` Roland Dreier
2008-05-27  4:20                               ` Arjan van de Ven
2008-05-27  7:08                             ` Benjamin Herrenschmidt
2008-05-27 15:50                               ` Roland Dreier
2008-05-27 16:37                                 ` James Bottomley
2008-05-27 17:38                                   ` Roland Dreier
2008-05-27 17:53                                     ` James Bottomley
2008-05-27 18:07                                       ` Roland Dreier
2008-05-27 18:17                                         ` Roland Dreier
2008-05-27 21:23                                         ` Chris Friesen
2008-05-27 21:29                                           ` Roland Dreier
2008-05-27 23:04                                           ` Paul Mackerras
2008-05-27 21:11                                 ` Benjamin Herrenschmidt
2008-05-27 21:33                                   ` Roland Dreier
2008-05-27 22:13                                     ` Benjamin Herrenschmidt
2008-05-27 22:39                                       ` Roland Dreier
2008-05-29 14:47                                     ` Jes Sorensen
2008-05-29 15:01                                       ` James Bottomley
2008-05-30  9:36                                         ` Jes Sorensen
2008-05-30 17:21                                           ` Jesse Barnes
2008-05-31  7:57                                             ` Jeremy Higdon
2008-05-29 21:40                                       ` Benjamin Herrenschmidt
2008-05-29 21:48                                         ` Trent Piepho
2008-05-29 22:05                                           ` Benjamin Herrenschmidt
2008-05-30  1:53                                             ` Trent Piepho
2008-05-29 21:53                                         ` Jesse Barnes
2008-05-30  9:39                                           ` Jes Sorensen
2008-05-30  9:48                                         ` Jes Sorensen
2008-05-31  8:14                                           ` Pavel Machek
2008-06-02  9:48                                             ` Jes Sorensen
2008-05-29 22:06                                       ` Roland Dreier
2008-05-29 22:25                                         ` Trent Piepho
2008-05-30  3:56                                           ` Paul Mackerras
2008-05-31  7:52                                       ` Jeremy Higdon
2008-06-02  9:56                                         ` Jes Sorensen
2008-06-02 21:02                                           ` Jeremy Higdon
2008-06-03  4:33                                           ` Nick Piggin
2008-06-03  8:15                                             ` Jeremy Higdon
2008-06-03  8:19                                               ` Nick Piggin
2008-06-03  8:45                                                 ` Jeremy Higdon
2008-06-03 16:52                                             ` Jesse Barnes
2008-06-05  8:40                                               ` Jes Sorensen
2008-06-05  8:43                                                 ` Benjamin Herrenschmidt
2008-06-12 15:07                                                   ` Matthew Wilcox
2008-06-13  0:07                                                     ` Benjamin Herrenschmidt
2008-05-31  8:04                                 ` Pavel Machek
2008-05-27  8:24                           ` Alan Cox
2008-05-27 15:28                     ` Jonathan Corbet
2008-05-20 22:55         ` [PATCH] [POWERPC] Improve (in|out)_beXX() asm code Trent Piepho
2008-05-21 14:01           ` Benjamin Herrenschmidt
2008-05-20 22:00   ` Trent Piepho
2008-05-21 14:00     ` Benjamin Herrenschmidt
2008-05-21 19:44       ` Trent Piepho
2008-05-21 20:41         ` Benjamin Herrenschmidt
2008-05-20 22:00 ` Andreas Schwab
2008-05-20 22:11   ` Trent Piepho
2008-05-20 22:47     ` Andreas Schwab
2008-05-20 23:14       ` Trent Piepho
2008-05-21  8:03         ` Andreas Schwab
2008-05-21 20:25           ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0805270943100.2958@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    --cc=tpiepho@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®