From: Jerry Stralko <gerb.stralko@gmail.com>
To: scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] scsi: remove CDROM not ready printk
Date: Tue, 27 May 2008 15:02:43 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0805271502370.3985@localhost.localdomain> (raw)
Hello,
This printk was spamming my dmesg and /var/log/message. Is there a
reason we have this printk? Can we simply remove it?
Signed-off-by: Jerry Stralko <gerb.stralko@gmail.com>
---
diff --git a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
index ae87d08..c37fb1c 100644
--- a/drivers/scsi/sr_ioctl.c
+++ b/drivers/scsi/sr_ioctl.c
@@ -238,8 +238,6 @@ int sr_do_ioctl(Scsi_CD *cd, struct packet_command *cgc)
break;
}
}
- if (!cgc->quiet)
- printk(KERN_INFO "%s: CDROM not ready. Make sure there is a disc in the drive.\n", cd->cdi.name);
#ifdef DEBUG
scsi_print_sense_hdr("sr", &sshdr);
#endif
next reply other threads:[~2008-05-27 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 19:02 Jerry Stralko [this message]
2008-05-29 7:41 ` Andrew Morton
2008-05-29 14:05 ` James Bottomley
2008-05-29 14:35 ` Gerb Stralko
2008-05-29 14:51 ` Matthew Wilcox
2008-05-29 14:55 ` James Bottomley
2008-05-29 15:04 ` Gerb Stralko
2008-05-29 15:22 ` James Bottomley
2008-06-02 0:45 ` Gerb Stralko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805271502370.3985@localhost.localdomain \
--to=gerb.stralko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®