From: Thomas Gleixner <tglx@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, pq@iki.fi, proski@gnu.org,
sandmann@redhat.com, a.p.zijlstra@chello.nl,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 1/5] ftrace: limit use of check pages
Date: Tue, 27 May 2008 17:34:04 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.1.10.0805271733120.3295@apollo.tec.linutronix.de> (raw)
In-Reply-To: <20080522042301.622087604@goodmis.org>
On Thu, 22 May 2008, Steven Rostedt wrote:
> The check_pages function is called often enough that it can cause problems
> with trace outputs or even bringing the system to a halt.
>
> This patch limits the check_pages to the places that are most likely to
> have problems. The check is made at the flip between the global array and
> the max save array, as well as when the size of the buffers changes and
> the self tests.
>
> This patch also removes the BUG_ON from check_pages and replaces it with
> a WARN_ON and disabling of the tracer.
Applied and fixed the typo.
> + tracing_disabled = 0; \
Thanks,
tglx
next prev parent reply other threads:[~2008-05-27 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 4:22 [PATCH 0/5] ftrace clean ups Steven Rostedt
2008-05-22 4:22 ` [PATCH 1/5] ftrace: limit use of check pages Steven Rostedt
2008-05-22 17:38 ` Pekka Paalanen
2008-05-22 17:43 ` Steven Rostedt
2008-05-22 18:06 ` [PATCH] ftrace: fix check_pages disable set Steven Rostedt
2008-05-27 15:34 ` Thomas Gleixner [this message]
2008-05-22 4:22 ` [PATCH 2/5] ftrace: remove wakeup functions from sched_switch tracer Steven Rostedt
2008-05-22 9:46 ` Peter Zijlstra
2008-05-22 4:22 ` [PATCH 3/5] ftrace: move ftrace_special to trace.c Steven Rostedt
2008-05-22 4:22 ` [PATCH 4/5] ftrace: add function tracing to wake up tracing Steven Rostedt
2008-05-22 4:22 ` [PATCH 5/5] ftrace: remove printks from irqsoff trace Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805271733120.3295@apollo.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pq@iki.fi \
--cc=proski@gnu.org \
--cc=rostedt@goodmis.org \
--cc=sandmann@redhat.com \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®