From: Thomas Gleixner <tglx@linutronix.de>
To: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
Cc: "Hans-Jürgen Koch" <hjk@linutronix.de>,
"Randy Dunlap" <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"Jan Altenberg" <jan.altenberg@linutronix.de>,
"Magnus Damm" <magnus.damm@gmail.com>
Subject: Re: [PATCH 1/1] UIO: Add a write() function to enable/disable interrupts
Date: Wed, 4 Jun 2008 09:05:43 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.1.10.0806040901400.3235@apollo.tec.linutronix.de> (raw)
In-Reply-To: <20080604063005.GA22952@digi.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 700 bytes --]
On Wed, 4 Jun 2008, Uwe Kleine-König wrote:
> Hello Hans-Jürgen,
>
> > Sometimes it is necessary to enable/disable the interrupt of a UIO device
> > from the userspace part of the driver. With this patch, the UIO kernel driver
> > can implement an "irqcontrol()" function that does this. Userspace can write
> > an s32 value to /dev/uioX (usually 0 or 1 to turn the irq off or on). The
> > UIO core will then call the driver's irqcontrol function.
> IMHO it would make sense to demand that irqcontrol() is idempotent and
> then call irqcontrol(ON) before blocking in read and poll.
We thought about that, but it is racy. Also explicit control is way
better than automagic hackery.
Thanks,
tglx
next prev parent reply other threads:[~2008-06-04 7:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 19:22 [PATCH 0/1] " Hans J. Koch
2008-05-22 19:26 ` [PATCH 1/1] " Hans J. Koch
2008-05-22 19:47 ` Tom Spink
2008-05-22 20:08 ` Hans J. Koch
2008-05-22 20:26 ` Tom Spink
2008-05-23 5:41 ` Uwe Kleine-König
2008-05-23 8:51 ` Hans J. Koch
2008-05-23 11:48 ` Tom Spink
2008-05-23 11:58 ` Uwe Kleine-König
2008-05-23 12:00 ` Tom Spink
2008-05-23 12:14 ` Hans J. Koch
2008-05-23 12:20 ` Tom Spink
2008-05-23 13:01 ` Hans J. Koch
2008-05-23 5:55 ` Uwe Kleine-König
2008-05-23 8:44 ` Hans J. Koch
2008-05-23 9:10 ` Uwe Kleine-König
2008-05-23 10:03 ` Hans J. Koch
2008-05-23 10:56 ` Uwe Kleine-König
2008-05-23 11:55 ` Hans J. Koch
2008-05-23 12:03 ` Uwe Kleine-König
2008-05-23 18:36 ` Randy Dunlap
2008-05-23 22:49 ` Hans-Jürgen Koch
2008-06-04 6:30 ` Uwe Kleine-König
2008-06-04 7:05 ` Thomas Gleixner [this message]
2008-05-23 20:44 ` Leon Woestenberg
2008-05-23 22:43 ` Hans J. Koch
2008-05-24 0:02 ` Leon Woestenberg
2008-05-24 4:43 ` Greg KH
2008-05-24 22:20 ` Hans J. Koch
2008-05-24 22:22 ` Thomas Gleixner
2008-05-24 22:34 ` Tom Spink
2008-05-24 22:46 ` Thomas Gleixner
2008-05-24 23:00 ` Tom Spink
2008-05-27 17:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0806040901400.3235@apollo.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=Uwe.Kleine-Koenig@digi.com \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=jan.altenberg@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®