mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Robert Richter <robert.richter@amd.com>
Cc: Ingo Molnar <mingo@elte.hu>, Yinghai Lu <yhlu.kernel@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] fix build bug in "x86: add PCI extended config space access for AMD Barcelona"
Date: Thu, 5 Jun 2008 22:41:26 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.1.10.0806052239110.3235@apollo.tec.linutronix.de> (raw)
In-Reply-To: <20080605185706.35A3B806B@erda.amd.com>

On Thu, 5 Jun 2008, Robert Richter wrote:
> --- a/include/asm-x86/mmconfig.h
> +++ b/include/asm-x86/mmconfig.h
> @@ -9,10 +9,4 @@ static inline void fam10h_check_enable_mmcfg(void) { }
>  static inline void check_enable_amd_mmconf_dmi(void) { }
>  #endif
>  
> -#if defined(CONFIG_SMP) && defined(CONFIG_X86_64)
> -extern void __cpuinit amd_enable_pci_ext_cfg(struct cpuinfo_x86 *c);
> -#else
> -static inline void amd_enable_pci_ext_cfg(struct cpuinfo_x86 *c) { }
> -#endif
> -

Can we please remove this superflous arch/x86/kernel/setup.h file,
which has a length/content ratio of 26:1. This removes the ugly
"../setup.h" includes

Thanks,
	tglx

  reply	other threads:[~2008-06-05 20:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080602143830.GA6835@elte.hu>
2008-06-03 17:37 ` Robert Richter
2008-06-04 15:11   ` Robert Richter
2008-06-05 17:32     ` Robert Richter
2008-06-05 20:41       ` Thomas Gleixner [this message]
2008-06-06 10:01         ` [PATCH] fix build bug in "x86: add PCI extended config space access for AMD Barcelona" (try #3) Robert Richter
2008-06-10 10:33           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0806052239110.3235@apollo.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=andi@firstfloor.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=robert.richter@amd.com \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®