From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758115AbYFLAZk (ORCPT ); Wed, 11 Jun 2008 20:25:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752392AbYFLAZb (ORCPT ); Wed, 11 Jun 2008 20:25:31 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41553 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbYFLAZa (ORCPT ); Wed, 11 Jun 2008 20:25:30 -0400 Date: Wed, 11 Jun 2008 17:24:48 -0700 (PDT) From: Linus Torvalds To: Len Brown cc: Andrew Morton , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, Linux Power Management List Subject: Re: [GIT PATCH] ACPI patches for 2.6.26-rc5 In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Jun 2008, Len Brown wrote: > > 27 files changed, 255 insertions(+), 180 deletions(-) Hmm. I get very different statistics: 27 files changed, 434 insertions(+), 359 deletions(-) You seem to use "git diff -w" to ignore whitespace changes, which explains it, but please don't - it makes it harder to compare with expected results, and it hides some changes entirely. I do agree that using '-w' is often useful, but especially for the purpose of letting people know what changed it kind of avoids the point by hiding many things. Linus