From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeff Chua <jeff.chua.linux@gmail.com>
Cc: Hugh Dickins <hugh@veritas.com>, Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, stable@kernel.org,
Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Dave Jones <davej@redhat.com>,
Chuck Wolber <chuckw@quantumlinux.com>,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
Michael Krufky <mkrufky@linuxtv.org>,
Chuck Ebbert <cebbert@redhat.com>,
Domenico Andreoli <cavokz@gmail.com>, Willy Tarreau <w@1wt.eu>,
Rodrigo Rubira Branco <rbranco@la.checkpoint.com>,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
Oleg Nesterov <oleg@tv-sign.ru>, Nick Piggin <npiggin@suse.de>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Ingo Molnar <mingo@elte.hu>, Roland McGrath <roland@redhat.com>
Subject: Re: [patch 2/5] Reinstate ZERO_PAGE optimization in get_user_pages() and fix XIP
Date: Mon, 23 Jun 2008 11:32:54 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0806231129410.2926@woody.linux-foundation.org> (raw)
In-Reply-To: <b6a2187b0806231115t55bf58cfgdc27a2d265258aab@mail.gmail.com>
On Tue, 24 Jun 2008, Jeff Chua wrote:
> On Tue, Jun 24, 2008 at 1:27 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>
> > On the other hand, if you add a trace to the "use_zero_page()" function to
> > print out the vm_flags and other details, that probably would help.
>
> Let me know if you still want me to test this.
No, it's fine. It really was a bug, and a long-standing one, just one that
was probably practically impossible to hit before (because we used to only
do the FOLL_ANON logic on missing whole page tables, and just about any
access to any mapping even nearby the one you care about will fill in the
page tables - so you would have had to be really unlucky to trigger the
case before).
The patch clearly fixes an issue, and makes the code more readable and
maintainable too, so I don't care what the exact mapping flags etc were.
> Yeh, it works great! Thank you.
Thanks for bisecting, reporting and testing.
Linus
next prev parent reply other threads:[~2008-06-23 18:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080622185327.348377223@mini.kroah.org>
2008-06-22 19:01 ` [patch 0/5] 2.6.25-stable review Greg KH
2008-06-22 19:01 ` [patch 4/5] x86: use BOOTMEM_EXCLUSIVE on 32-bit Greg KH
2008-06-22 20:22 ` Johannes Weiner
2008-06-22 20:30 ` Greg KH
2008-06-22 20:36 ` Adrian Bunk
2008-06-22 20:36 ` Linus Torvalds
2008-06-23 8:09 ` Ingo Molnar
2008-06-23 10:33 ` Bernhard Walle
2008-06-23 10:53 ` Ingo Molnar
2008-06-23 13:21 ` Bernhard Walle
2008-06-23 19:20 ` [stable] " Greg KH
2008-06-23 19:36 ` Ingo Molnar
2008-06-22 19:01 ` [patch 3/5] sctp: Make sure N * sizeof(union sctp_addr) does not overflow Greg KH
2008-06-22 19:23 ` David Miller
2008-06-22 20:28 ` Greg KH
2008-06-23 21:36 ` David Miller
2008-06-23 21:43 ` Greg KH
2008-06-22 19:01 ` [patch 2/5] Reinstate ZERO_PAGE optimization in get_user_pages() and fix XIP Greg KH
2008-06-22 19:22 ` Linus Torvalds
2008-06-22 20:29 ` Greg KH
2008-06-23 15:32 ` Jeff Chua
2008-06-23 16:04 ` Hugh Dickins
2008-06-23 16:39 ` Linus Torvalds
2008-06-23 17:05 ` Jeff Chua
2008-06-23 17:27 ` Linus Torvalds
2008-06-23 18:15 ` Jeff Chua
2008-06-23 18:32 ` Linus Torvalds [this message]
2008-06-22 19:01 ` [patch 1/5] atl1: relax eeprom mac address error check Greg KH
2008-06-22 19:01 ` [patch 5/5] x86: set PAE PHYSICAL_MASK_SHIFT to 44 bits gregkh
2008-06-23 11:19 ` [patch 0/5] 2.6.25-stable review S.Çağlar Onur
2008-06-23 19:30 ` [stable] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0806231129410.2926@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cavokz@gmail.com \
--cc=cebbert@redhat.com \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=gregkh@suse.de \
--cc=hugh@veritas.com \
--cc=jeff.chua.linux@gmail.com \
--cc=jmforbes@linuxtx.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mkrufky@linuxtv.org \
--cc=npiggin@suse.de \
--cc=oleg@tv-sign.ru \
--cc=rbranco@la.checkpoint.com \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=roland@redhat.com \
--cc=stable@kernel.org \
--cc=tytso@mit.edu \
--cc=w@1wt.eu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome