From: Linus Torvalds <torvalds@linux-foundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Randy Dunlap <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT pull] timer updates for 2.6.27
Date: Tue, 15 Jul 2008 10:59:18 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0807151046180.3017@woody.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0807141827340.3283@apollo.tec.linutronix.de>
On Mon, 14 Jul 2008, Thomas Gleixner wrote:
>
> Please pull the latest timers/for-linus git tree from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git timers/for-linus
> ...
> Randy Dunlap (1):
> acpi_pm clccksource: fix printk format warning
This just _adds_ a warning. I now get
drivers/clocksource/acpi_pm.c:231: warning: format ‘%04x’ expects type ‘unsigned int’, but argument 3 has type ‘long unsigned int’
Why? Because it only adds the (unsigned int) cast (which is wrong anyway -
ioports really should be long) to the ioport value, not 'base' is still
'unsigned long', and it removed the 'lx' from the latter too.
One clean fix is probably to just make pmtmr_ioport be of type 'unsigned
long'. It's the right thing from a portability angle anyway - even if no
architecture that uses ACPI will likely ever have ioports that are long
anyway.
The alternative - and probably better, but _much_ more intrusive - patch
is to make 'u32' just be 'unsigned int' on x86-32, along with making 'u64'
be 'unsigned long long' on x86-64, which would unify more types.
Anyway, I'm not fixing it right now, since it's unclear which way to go,
but this need to be fixed _some_ way.
Linus
next prev parent reply other threads:[~2008-07-15 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 16:28 Thomas Gleixner
2008-07-15 17:59 ` Linus Torvalds [this message]
2008-07-15 18:01 ` Linus Torvalds
2008-07-15 18:59 ` [PATCH] acpi_pm: re-fix printk format (was: timer updates for 2.6.27) Randy Dunlap
2008-09-09 20:32 [GIT pull] timer updates for 2.6.27 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0807151046180.3017@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®