From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761808AbYGOSCj (ORCPT ); Tue, 15 Jul 2008 14:02:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755145AbYGOSCb (ORCPT ); Tue, 15 Jul 2008 14:02:31 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:39402 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753688AbYGOSCa (ORCPT ); Tue, 15 Jul 2008 14:02:30 -0400 Date: Tue, 15 Jul 2008 11:01:29 -0700 (PDT) From: Linus Torvalds To: Thomas Gleixner cc: LKML , Ingo Molnar , Randy Dunlap , Andrew Morton Subject: Re: [GIT pull] timer updates for 2.6.27 In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Jul 2008, Linus Torvalds wrote: > > Anyway, I'm not fixing it right now, since it's unclear which way to go, > but this need to be fixed _some_ way. What the hell. The second type is always "unsigned long", and needs to be that since it's passed in as a pointer to "strict_strtoul()". So regardless of whether the cast to the first port should be removed or not, the second thing should be 0x%04lx. Linus