From: Thomas Gleixner <tglx@linutronix.de>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Dmitry Adamushko <dmitry.adamushko@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Thomas Meyer <thomas@m3y3r.de>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: -git: BUG: unable to handle kernel paging request at c0100248 [CPU hotplug]
Date: Sun, 27 Jul 2008 21:23:10 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.1.10.0807272118460.574@apollo.tec.linutronix.de> (raw)
In-Reply-To: <19f34abd0807271019i2112498ay57c267354bd63a8c@mail.gmail.com>
On Sun, 27 Jul 2008, Vegard Nossum wrote:
> Booting processor 1/1 ip 6000
> Initializing CPU#1
> [...]
> Write protecting the kernel text: 5648k
>
> So it succeeds because the protection happens much later :-)
Patch below fixes the issue. I get it to Linus ASAP.
Thanks,
tglx
---------
diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
index f67e934..a7010c3 100644
--- a/arch/x86/kernel/head_32.S
+++ b/arch/x86/kernel/head_32.S
@@ -456,9 +456,6 @@ is386: movl $2,%ecx # set MP
1:
#endif /* CONFIG_SMP */
jmp *(initial_code)
-.align 4
-ENTRY(initial_code)
- .long i386_start_kernel
/*
* We depend on ET to be correct. This checks for 287/387.
@@ -601,6 +598,11 @@ ignore_int:
#endif
iret
+.section .cpuinit.data,"wa"
+.align 4
+ENTRY(initial_code)
+ .long i386_start_kernel
+
.section .text
/*
* Real beginning of normal "text" segment
next prev parent reply other threads:[~2008-07-27 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 9:55 Vegard Nossum
2008-07-27 10:07 ` Vegard Nossum
2008-07-27 17:14 ` Dmitry Adamushko
2008-07-27 17:19 ` Vegard Nossum
2008-07-27 19:23 ` Thomas Gleixner [this message]
2008-07-27 19:35 ` Vegard Nossum
2008-07-27 19:40 ` Vegard Nossum
2008-07-28 18:34 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0807272118460.574@apollo.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=dmitry.adamushko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
--cc=vegard.nossum@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®