From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508AbYG3Uzf (ORCPT ); Wed, 30 Jul 2008 16:55:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751337AbYG3UzZ (ORCPT ); Wed, 30 Jul 2008 16:55:25 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:60281 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbYG3UzY (ORCPT ); Wed, 30 Jul 2008 16:55:24 -0400 Date: Wed, 30 Jul 2008 13:51:36 -0700 (PDT) From: Linus Torvalds To: Miklos Szeredi cc: jens.axboe@oracle.com, akpm@linux-foundation.org, nickpiggin@yahoo.com.au, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch v3] splice: fix race with page invalidation In-Reply-To: Message-ID: References: <20080730175406.GN20055@kernel.dk> <20080730194516.GO20055@kernel.dk> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jul 2008, Miklos Szeredi wrote: > > It _is_ a bug fix. No it's not. It's still papering over a totally unrelated bug. It's not a "fix", it's a "paper-over". It doesn't matter if _behaviour_ changes. Can you really not see the difference? Afaik, everybody pretty much agreed what the real fix should be (don't mark the page not up-to-date, just remove it from the radix tree), I'm not seeing why you continue to push the patch that ALREADY GOT NAK'ed. Linus