mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, axboe@kernel.dk
Subject: [PATCH] BLOCK: Simplify the Kconfig structure for the BLOCK layer.
Date: Mon, 4 Aug 2008 13:50:16 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0808041347270.7208@localhost.localdomain> (raw)


Given that everything in block/Kconfig and block/Kconfig.iosched
depends on "BLOCK", might as well just wrap the entire contents in a
single conditional and remove the unnecessary tests.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  unless there's something tricky or obscure that can happen in the
block layer that *doesn't* depend on BLOCK, this should be a
reasonable simplification.


 block/Kconfig         |    6 +++---
 block/Kconfig.iosched |    4 ----
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/block/Kconfig b/block/Kconfig
index 1ab7c15..66cfacd 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -93,11 +93,11 @@ config BLK_DEV_INTEGRITY
 	T10/SCSI Data Integrity Field or the T13/ATA External Path
 	Protection.  If in doubt, say N.

-endif # BLOCK
-
 config BLOCK_COMPAT
 	bool
-	depends on BLOCK && COMPAT
+	depends on COMPAT
 	default y

 source block/Kconfig.iosched
+
+endif # BLOCK
diff --git a/block/Kconfig.iosched b/block/Kconfig.iosched
index 7e803fc..5ada7f1 100644
--- a/block/Kconfig.iosched
+++ b/block/Kconfig.iosched
@@ -1,5 +1,3 @@
-if BLOCK
-
 menu "IO Schedulers"

 config IOSCHED_NOOP
@@ -69,5 +67,3 @@ config DEFAULT_IOSCHED
 	default "noop" if DEFAULT_NOOP

 endmenu
-
-endif

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

                 reply	other threads:[~2008-08-04 17:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0808041347270.7208@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=akpm@osdl.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®