From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754276AbYHEE2j (ORCPT ); Tue, 5 Aug 2008 00:28:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752515AbYHEEZc (ORCPT ); Tue, 5 Aug 2008 00:25:32 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:57010 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbYHEEZc (ORCPT ); Tue, 5 Aug 2008 00:25:32 -0400 Date: Mon, 4 Aug 2008 21:25:29 -0700 (PDT) From: Linus Torvalds To: Nick Piggin cc: Andrew Morton , Linux Kernel Mailing List Subject: Re: Switching TestSetPageLocked to trylock_page In-Reply-To: <200808051341.53282.nickpiggin@yahoo.com.au> Message-ID: References: <200807311726.51816.nickpiggin@yahoo.com.au> <200808051314.33791.nickpiggin@yahoo.com.au> <200808051341.53282.nickpiggin@yahoo.com.au> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Aug 2008, Nick Piggin wrote: > > The part that helps x86 is another patch further down my stack, which > can avoid looking at the hashed page waitqueue at unlock_page-time. > Basically this eliminates the entire page waitqueue from the cache > footprint of fastpath workloads where the lock is uncontended (often: > page faulting, write(2), writeout etc). Hmm. Tell me more. Contention bit? Linus