From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: ebiederm@xmission.com, ying.huang@intel.com, pavel@ucw.cz,
nigel@nigel.suspend2.net, rjw@sisk.pl, vgoyal@redhat.com,
mingo@elte.hu, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org
Subject: Re: [PATCH] kexec jump: fix compiling warning on xchg(&kexec_lock, 0) in kernel_kexec()
Date: Wed, 13 Aug 2008 13:31:24 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0808131328380.3462@nehalem.linux-foundation.org> (raw)
In-Reply-To: <20080813132535.6cd4bab6.akpm@linux-foundation.org>
On Wed, 13 Aug 2008, Andrew Morton wrote:
>
> #2:
I thought you said there were things that want to sleep in the region?
If so, spinlocks will work as long as you don't have CONFIG_PREEMPT or
lock validation (there's no way to deadlock thanks to all the lock getters
using the "trylock" variant), but will blow up because a successful
trylock will obviously also disable preemption and/or trigger all the lock
detection.
So if there are potential sleepers, you'd need the mutex instead.
Linus
next prev parent reply other threads:[~2008-08-13 20:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 9:12 Huang Ying
2008-08-13 9:27 ` Andrew Morton
2008-08-13 17:01 ` Linus Torvalds
2008-08-13 17:25 ` Andrew Morton
2008-08-13 17:59 ` Ingo Molnar
2008-08-13 16:57 ` Linus Torvalds
2008-08-13 18:12 ` Eric W. Biederman
2008-08-13 18:31 ` Vivek Goyal
2008-08-13 19:44 ` Andrew Morton
2008-08-13 19:50 ` Linus Torvalds
2008-08-13 20:07 ` Andrew Morton
2008-08-13 20:13 ` Linus Torvalds
2008-08-13 20:25 ` Andrew Morton
2008-08-13 20:31 ` Linus Torvalds [this message]
2008-08-13 20:41 ` Andrew Morton
2008-08-13 21:21 ` Vivek Goyal
2008-08-13 22:17 ` Linus Torvalds
2008-08-13 20:15 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0808131328380.3462@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=vgoyal@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®