From: Linus Torvalds <torvalds@linux-foundation.org>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
Avi Kivity <avi@qumranet.com>,
virtualization@lists.linux-foundation.org,
Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH] virtio_balloon: fix towards_target when deflating balloon
Date: Mon, 18 Aug 2008 21:17:12 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0808182115210.3324@nehalem.linux-foundation.org> (raw)
In-Reply-To: <48AA1D5E.5050405@us.ibm.com>
On Mon, 18 Aug 2008, Anthony Liguori wrote:
>
> Nothing. It works just fine. However, I implemented it more verbosely
> because this is the second time we've "fixed" this problem. See
>
> commit bdc1681cdf1ab6a65fa935a2b3f8fc63b20c54ea
> Author: Rusty Russell <rusty@rustcorp.com.au>
> Date: Mon Mar 17 22:58:15 2008 -0500
>
> virtio: handle > 2 billion page balloon targets
Well, we could perhaps add a sparse warning that makes noise when a
unsigned subtraction is cast to a wider signed field. I dunno if it would
catch anything interesting, or just cause a ton of irritating noise.
> So I thought I'd rely a little less on the subtleties of promotion and make
> things a bit more clear. However, I don't feel that strongly about it so here
> you go.
Ugly and inefficient is not acceptable, even for these kinds of reasons.
So yes, the simpler version is much better.
Linus
next prev parent reply other threads:[~2008-08-19 4:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 22:15 Anthony Liguori
2008-08-19 0:42 ` Linus Torvalds
2008-08-19 1:09 ` Anthony Liguori
2008-08-19 4:17 ` Linus Torvalds [this message]
2008-08-19 1:22 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0808182115210.3324@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=aliguori@us.ibm.com \
--cc=avi@qumranet.com \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®