From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756916AbYH2Q4Z (ORCPT ); Fri, 29 Aug 2008 12:56:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752760AbYH2Q4Q (ORCPT ); Fri, 29 Aug 2008 12:56:16 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44655 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587AbYH2Q4P (ORCPT ); Fri, 29 Aug 2008 12:56:15 -0400 Date: Fri, 29 Aug 2008 09:55:51 -0700 (PDT) From: Linus Torvalds To: Yinghai Lu cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Jesse Barnes , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: split e820 reserved entries record to late v4 - fix In-Reply-To: <86802c440808290937y468a4368y9b6ed57ca0cb9896@mail.gmail.com> Message-ID: References: <1219997592-9975-1-git-send-email-yhlu.kernel@gmail.com> <86802c440808290937y468a4368y9b6ed57ca0cb9896@mail.gmail.com> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Aug 2008, Yinghai Lu wrote: > > > > void insert_resource_expand_to_fit(struct resource *root, struct resource *new) > > { > > write_lock(&resource_lock); > > while (new->start && new->parent) { That should obviously be while (new->start && !new->parent) { ^^^ oops. I told you it was untested ;) Linus