From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754537AbYIBVRR (ORCPT ); Tue, 2 Sep 2008 17:17:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752374AbYIBVRD (ORCPT ); Tue, 2 Sep 2008 17:17:03 -0400 Received: from www.tglx.de ([62.245.132.106]:47334 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbYIBVRB (ORCPT ); Tue, 2 Sep 2008 17:17:01 -0400 Date: Tue, 2 Sep 2008 23:16:20 +0200 (CEST) From: Thomas Gleixner To: Alok Kataria cc: Linus Torvalds , Larry Finger , LKML , "Rafael J. Wysocki" , Michael Buesch Subject: Re: Regression in 2.6.27 caused by commit bfc0f59 In-Reply-To: <1220380907.3929.10.camel@alok-dev1> Message-ID: References: <48BB2116.1060904@lwfinger.net> <48BC2A03.9000104@lwfinger.net> <1220380907.3929.10.camel@alok-dev1> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Sep 2008, Alok Kataria wrote: > On Tue, 2008-09-02 at 11:14 -0700, Thomas Gleixner wrote: > > I think that information is enough to give us a pretty precice idea > > when to discard the result. I'm currently looking at the hpet/pmtimer > > values for comparison and I should have a patch for testing ready > > later tonight. > > > Sorry for joining the party this late...am still going through all my > mails. > > Ok, so from what I understand until now, we will calibrate TSC against > PIT as was done in 32bit code and use that as default. If that fails to > give any sane results we will fall back to calibrating against PM_timer > or HPET ? > Thomas has already explained the problem with 32bit calibration ( i.e. > just against PIT and no checks for SMI's and all) but would like to > point that this problem is lot more worse in virtualized environment, > because we may fail to get sane values even from multiple loops of > calibrating against PIT. > If we have a fall back mechanism to detect this SMI event, and then try > calibrating against PM timer or HPET we should be good. I still keep the fallback against pmtimer/hpet alive. Thanks, tglx