mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert commit e8aa4667baf74dfd85fbaab86861465acb811085
Date: Thu, 4 Sep 2008 18:14:38 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.1.10.0809041812450.3243@apollo.tec.linutronix.de> (raw)
In-Reply-To: <20080904153206.GB7120@elte.hu>

On Thu, 4 Sep 2008, Ingo Molnar wrote:

> 
> * Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
> 
> > This reverts commit e8aa4667baf74dfd85fbaab86861465acb811085
> >  (x86: enable hpet=force for AMD SB400)
> > 
> > Since ATI/AMD decided not to support HPET on SB4xx it doesn't
> > make sense to enable this unsupported feature.
> > (I was not aware of this when submitting the quirk.)
> > 
> > If a system with SB4xx chipset provides an ACPI HPET table and does
> > not boot, "nohpet" should be used as kernel parameter.
> > 
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> 
> applied to tip/x86/urgent, thanks Andreas. I guess a system broke due to 
> this commit?

Hmm, why do we remove something which needs to be force enabled by the
user anyway ?  

Is the HPET on these systems not working at all so the force enable
code is useless ?

Thanks,
	
	tglx

  reply	other threads:[~2008-09-04 16:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04 14:46 Andreas Herrmann
2008-09-04 15:32 ` Ingo Molnar
2008-09-04 16:14   ` Thomas Gleixner [this message]
2008-09-04 16:17     ` Ingo Molnar
2008-09-05 12:42     ` Andreas Herrmann
2008-09-05 14:03       ` Thomas Gleixner
2008-09-05 16:33         ` [PATCH] x86: hpet: modify IXP400 quirk to enable interrupts Andreas Herrmann
2008-09-05 16:59           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0809041812450.3243@apollo.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=andreas.herrmann3@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®