From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754724AbYIEFKf@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754724AbYIEFKf (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Sep 2008 01:10:35 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751514AbYIEFJ4
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 5 Sep 2008 01:09:56 -0400
Received: from relais.videotron.ca ([24.201.245.36]:52997 "EHLO
	relais.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751232AbYIEFJy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Sep 2008 01:09:54 -0400
MIME-version: 1.0
Content-transfer-encoding: 7BIT
Content-type: TEXT/PLAIN; charset=US-ASCII
Date: Fri, 05 Sep 2008 01:09:48 -0400 (EDT)
From: Nicolas Pitre <nico@cam.org>
X-X-Sender: nico@xanadu.home
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Dmitry Torokhov <dtor@insightbb.com>, lkml <linux-kernel@vger.kernel.org>,
       akpm <akpm@osdl.org>, linux-next@vger.kernel.org
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
In-reply-to: <20080904214444.0dccf859.randy.dunlap@oracle.com>
Message-id: <alpine.LFD.1.10.0809050104560.23787@xanadu.home>
References: <20061209003635.e778ff76.randy.dunlap@oracle.com>
 <200612092150.02940.dtor@insightbb.com>
 <20061209185737.1768315d.randy.dunlap@oracle.com>
 <200612092205.19358.dtor@insightbb.com>
 <Pine.LNX.4.64.0612092212410.2630@xanadu.home>
 <20061209210945.5abe2d89.randy.dunlap@oracle.com>
 <Pine.LNX.4.64.0612102244140.2630@xanadu.home>
 <20080904195744.f367cd2d.randy.dunlap@oracle.com>
 <alpine.LFD.1.10.0809050028590.23787@xanadu.home>
 <20080904214444.0dccf859.randy.dunlap@oracle.com>
User-Agent: Alpine 1.10 (LFD 962 2008-03-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 4 Sep 2008, Randy Dunlap wrote:

> On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
> 
> > On Thu, 4 Sep 2008, Randy Dunlap wrote:
> > 
> > > On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
> > > 
> > > > On Sat, 9 Dec 2006, Randy Dunlap wrote:
> > > > 
> > > > > On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
> > > > > 
> > > > > > Please consider what SND_CONFIG_AC97_BUS corresponds to.  It is 
> > > > > > sound/pci/ac97/ac97_bus.c and if you look into this file you'll see that 
> > > > > > it is perfectly buildable even if sound is entirely configured out, just 
> > > > > > like some lib code would be.
> > > > > 
> > > > > OK.  Should it (CONFIG_SND_AC97_BUS -> sound/pci/ac97/ac97_bus.c)
> > > > > be buildable when sound is disabled?
> > > > 
> > > > Yes.
> > > > 
> > > > > If so, where should it be moved to (since afaik, make won't even
> > > > > descend into sound/ if SOUND=n; I don't see that changing
> > > > > any time soon).
> > > > 
> > > > What about this patch?
> > > 
> > > Can we get this patch or some patch into the input tree for linux-next?
> > 
> > This patch is commit e1036502e5263851259d147771226161e5ccc85a and 
> > appeared in mainline almost 2 years ago.
> 
> Ack.  Sorry about that.  Wrong ucb thread.
> 
> ucb1400_core still has build errors in linux-next
> since it uses ac97_bus_type even when CONFIG_SOUND=n.

Both sound (AC97) and UCB1400 should be able to select CONFIG_AC97_BUS 
independently from each other.

And in linux/sound/Makefile one can find this note:

	# This one must be compilable even if sound is configured out
	obj-$(CONFIG_AC97_BUS) += ac97_bus.o

This was fixed 2 years ago.  Who broke it this time?


Nicolas