From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754908AbYIFUzg (ORCPT ); Sat, 6 Sep 2008 16:55:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752854AbYIFUz1 (ORCPT ); Sat, 6 Sep 2008 16:55:27 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:39484 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752600AbYIFUz1 (ORCPT ); Sat, 6 Sep 2008 16:55:27 -0400 Date: Sat, 6 Sep 2008 13:55:07 -0700 (PDT) From: Linus Torvalds To: Thomas Gleixner cc: Alok Kataria , Alan Cox , LKML , Arjan van de Veen , "H. Peter Anvin" , Peter Zijlstra , Dan Hecht , Garrett Smith Subject: Re: [RFC patch 0/4] TSC calibration improvements In-Reply-To: Message-ID: References: <20080904160036.GA18382@elte.hu> <20080904190728.59634020@lxorguk.ukuu.org.uk> <20080904204305.GA29065@elte.hu> <20080904205236.GA3864@elte.hu> <20080904213350.GA15678@elte.hu> <1220653095.14401.72.camel@alok-dev1> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 6 Sep 2008, Linus Torvalds wrote: > > > On Sat, 6 Sep 2008, Thomas Gleixner wrote: > > > > Just checked. The -tip version still has the expect-- in the for() > > which might lead to stupid results depending on the gcc madness level. > > Umm. What? You're on some odd drugs. Oh, you mean te "--expect" in the last pit_expect_msb(). Yeah, that one looks bogus, but I don't understand what it has to do with gcc at all. "expect" is an unsigned char. There are absolutely _zero_ issues with overflow, underflow, random phases of the moon, madness levels or anything else. But yes, it does look like Ingo screwed up when adding that final check, since expect was already decremented at the end of the loop. Ingo? Did you actually test it? Linus