From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762553AbYJKUwe (ORCPT ); Sat, 11 Oct 2008 16:52:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760565AbYJKUwY (ORCPT ); Sat, 11 Oct 2008 16:52:24 -0400 Received: from ftp.linux-mips.org ([213.58.128.207]:41432 "EHLO ftp.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754635AbYJKUwX (ORCPT ); Sat, 11 Oct 2008 16:52:23 -0400 Date: Sat, 11 Oct 2008 21:52:18 +0100 (BST) From: "Maciej W. Rozycki" To: Alan Cox cc: Linux Kernel Mailing List , mingo@elte.hu, torvalds@linux-foundation.org Subject: Re: Looks broken to me: x86, cyrix: debug In-Reply-To: <20081011214043.283a3330@lxorguk.ukuu.org.uk> Message-ID: References: <200810112003.m9BK3Wwu025556@hera.kernel.org> <20081011214043.283a3330@lxorguk.ukuu.org.uk> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Oct 2008, Alan Cox wrote: > > +#define getCx86_old(reg) ({ outb((reg), 0x22); inb(0x23); }) > > Doesn't expand to any kind of returned value. Well, actually it returns the value of the inb() expression -- cf the semantics of compound statements. The rest looks suspicious indeed. Maciej