mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Pitre <nico@cam.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Christoph Lameter <cl@linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: wrong usage of MAX_DMA_ADDRESS in bootmem.h
Date: Tue, 30 Sep 2008 17:09:49 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0809301648240.3635@xanadu.home> (raw)
In-Reply-To: <20080930201224.GL15911@flint.arm.linux.org.uk>

On Tue, 30 Sep 2008, Russell King - ARM Linux wrote:

> As we have already covered in the past, CONFIG_ZONE_DMA has to always
> be enabled on ARM because ARM always puts all memory in the first zone.
> To do otherwise introduces lots of special cases, and I steadfastly
> refuse to make the memory initialisation any more complicated than it
> already is.

I just tried this:

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 70dba16..8f609cc 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -148,7 +148,6 @@ config ARCH_MAY_HAVE_PC_FDC
 
 config ZONE_DMA
 	bool
-	default y
 
 config GENERIC_ISA_DMA
 	bool

with no other changes what so ever.  And the resulting kernel still 
works fine, with this difference:

|On node 0 totalpages: 131072
|free_area_init_node: node 0, pgdat c03c5e00, node_mem_map c03e7000
|  Normal zone: 130048 pages, LIFO batch:31

instead of:

|On node 0 totalpages: 131072
|free_area_init_node: node 0, pgdat c03c7e58, node_mem_map c03e9000
|  DMA zone: 130048 pages, LIFO batch:31

And the resulting kernel is also smaller:

|   text    data     bss     dec     hex filename
|3826182  102384  111700 4040266  3da64a vmlinux
|3823593  101616  111700 4036909  3d992d vmlinux.nodmazone

So maybe CONFIG_DMA_ZONE could be selected only by those machines 
actually defining arch_adjust_zones() ?

> And besides, this has nothing to do with that issue.

Indeed.  But still...


Nicolas

  reply	other threads:[~2008-09-30 21:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1222230419-15661-21-git-send-email-nico@cam.org>
     [not found] ` <1222230592-15868-1-git-send-email-nico@cam.org>
     [not found]   ` <20080930162809.GD15911@flint.arm.linux.org.uk>
     [not found]     ` <alpine.LFD.2.00.0809301409230.3635@xanadu.home>
     [not found]       ` <20080930184411.GJ15911@flint.arm.linux.org.uk>
2008-09-30 19:35         ` Nicolas Pitre
2008-09-30 19:56           ` Christoph Lameter
2008-09-30 20:12             ` Russell King - ARM Linux
2008-09-30 21:09               ` Nicolas Pitre [this message]
2008-10-01 12:07               ` Christoph Lameter
2008-10-01 14:06                 ` Russell King - ARM Linux
2008-10-01 14:50                   ` Christoph Lameter
2008-10-01 15:02                     ` Russell King - ARM Linux
2008-10-02 16:49                       ` Christoph Lameter
2008-10-02 19:06                         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0809301648240.3635@xanadu.home \
    --to=nico@cam.org \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®