From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [GIT] HID patches for 2.6.28
Date: Tue, 14 Oct 2008 12:41:44 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0810141236590.3288@nehalem.linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.1.10.0810140055060.26779@jikos.suse.cz>
On Tue, 14 Oct 2008, Jiri Kosina wrote:
>
> could you please pull from 'for-linus' branch of
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus
>
> to receive 2.6.28 patches for the HID (the HIDeously slow devices, you
> know) code.
This is really HIDeous. Disgusting.
The new Kconfig options are almost uselessly described, and very annoying
and this adds several new warnings of the type:
drivers/hid/hid-lg.c:342: warning: ‘hid_compat_logitech’ defined but not used
which is just unacceptable.
I have an entirely warningless build. I'm not going to break that over
something like this. Not pulled. Please fix.
As to the Kconfig options - do they really add so much space that you need
to ask for the quirks? You didn't use to. Can you make the questions
depend on EMBEDDED, or at least on the HID_COMPAT thing or whatever?
Linus
next prev parent reply other threads:[~2008-10-14 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 0:07 Jiri Kosina
2008-10-14 19:41 ` Linus Torvalds [this message]
2008-10-14 20:12 ` Jiri Kosina
2008-10-14 21:02 ` Harvey Harrison
2008-10-14 22:39 ` Jiri Kosina
2008-10-15 9:36 ` Ingo Molnar
2008-10-15 9:42 ` Jiri Kosina
2008-10-15 10:02 ` Ingo Molnar
2008-10-15 10:20 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810141236590.3288@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®