mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Bob Montgomery <bob.montgomery@hp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	vojtech@suse.cz, chandru@in.ibm.com
Subject: Re: [PATCH] disable CPU side GART accesses
Date: Wed, 15 Oct 2008 16:40:41 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0810151630050.3288@nehalem.linux-foundation.org> (raw)
In-Reply-To: <1224107317.2215.238.camel@amd.troyhebe>



On Wed, 15 Oct 2008, Bob Montgomery wrote:
> 
> This patch changes the initialization of the GART to set the DISGARTCPU
> bit in the GART Aperture Control Register (AMD64_GARTAPERTURECTL).
> Setting the bit prevents requests from the CPUs from accessing the
> GART.  In other words, CPU memory accesses to the aperture address
> range will not cause the GART to perform an address translation.
> The aperture area is currently being unmapped at the kernel level
> with set_memory_np() in gart_iommu_init to prevent accesses from the
> CPU [...]

Would this allow us to get rid of that particular hackup code sequence 
entirely? Or do we still need them for other chip versions etc?

Also, the whole iommu/gart thing seems to have a lot of people who have 
worked on it, are the right people cc'd? Pavel seems to have touched the 
code last, but it seems to be originally done by Andi and then with 
touches by DaveJ. 

I get the feeling that the people cc'd are kdump people, not iommu/gart 
people, which is a bit sad.

		Linus

  reply	other threads:[~2008-10-15 23:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 21:48 Bob Montgomery
2008-10-15 23:40 ` Linus Torvalds [this message]
2008-10-16 19:17   ` Bob Montgomery
2008-10-15 23:48 ` Ingo Molnar
2008-10-16  0:22   ` Yinghai Lu
2008-10-16 17:00     ` Bob Montgomery
2008-10-16 17:43       ` Yinghai Lu
2008-10-16 19:26         ` Bob Montgomery
2008-10-27 22:42   ` Bob Montgomery
2008-10-27 23:06     ` Yinghai Lu
2008-10-29 20:52       ` Bob Montgomery
2008-10-29 21:24         ` Dave Airlie
2008-10-29 21:32           ` Dave Jones
2008-10-29 21:40             ` Dave Airlie
2008-11-03 23:36               ` Bob Montgomery
2008-11-03 23:55                 ` Dave Airlie
2008-11-19 22:12                   ` Bob Montgomery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0810151630050.3288@nehalem.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=bob.montgomery@hp.com \
    --cc=chandru@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome