From: Linus Torvalds <torvalds@linux-foundation.org>
To: Greg KH <gregkh@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [GIT PATCH] USB patches for 2.6-git
Date: Fri, 17 Oct 2008 15:47:58 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0810171544320.3438@nehalem.linux-foundation.org> (raw)
In-Reply-To: <20081017220027.GA3659@kroah.com>
On Fri, 17 Oct 2008, Greg KH wrote:
>
> Here is the big batch of USB patches for your 2.6-git tree.
I really wish I were to get the occasional _clean_ pull for a change.
f*ck me, but why do people keep adding more and more warnings, and
apparently not even bother to write clean code? The merge window is no
excuse for badly written crap.
drivers/usb/host/ehci-hcd.c: In function ‘ehci_hcd_init’:
drivers/usb/host/ehci-hcd.c:1115: warning: label ‘err_debug’ defined but not used
That particular function is just about the ugliest thing I've ever seen,
and now it's adding annoying warnings too!
Yeah, I'm grumpy. The quality control during this merge window has been
absolutely disgusting. I feel like I have to complain about every other
pull I do, because people feel like another new warning isn't a problem.
And every single time, the new warning is due to some total crap code.
Linus
next prev parent reply other threads:[~2008-10-17 22:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 22:00 Greg KH
2008-10-17 22:47 ` Linus Torvalds [this message]
2008-10-17 23:00 ` Greg KH
2008-10-17 23:09 ` Greg KH
[not found] ` <gdfauh$hsp$1@ger.gmane.org>
2008-10-19 17:29 ` Greg KH
2008-10-19 19:37 ` Dmitry
2008-10-29 22:38 Greg KH
2008-11-13 23:02 Greg KH
2008-11-14 4:06 ` Gupta, Ajay Kumar
2008-11-14 19:15 ` Greg KH
2008-11-14 19:40 ` Sergei Shtylyov
2008-11-14 19:59 ` Greg KH
2008-11-14 20:10 ` Sergei Shtylyov
2008-11-14 20:55 ` Greg KH
2008-11-14 21:02 ` Sergei Shtylyov
2008-11-14 21:07 ` Greg KH
2008-12-17 19:27 Greg KH
2009-01-07 19:24 Greg KH
2009-01-07 20:23 ` Sergei Shtylyov
2009-01-07 21:28 ` Greg KH
2009-01-07 21:42 ` Sergei Shtylyov
2009-01-07 21:54 ` Andrew Morton
2009-01-07 22:48 ` David Brownell
2009-01-27 23:49 Greg KH
2009-01-27 23:56 ` Greg KH
2009-02-09 19:31 Greg KH
2009-02-27 22:45 Greg KH
2009-03-17 21:05 Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810171544320.3438@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®