mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] 8250: Oxford Semiconductor Devices
Date: Mon, 20 Oct 2008 09:46:50 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0810200944490.3518@nehalem.linux-foundation.org> (raw)
In-Reply-To: <20081017192830.9308.94462.stgit@localhost.localdomain>



This series was apparently never even compile-tested.

  drivers/serial/8250_pci.c:2525:37: warning: "/*" within comment
  drivers/serial/8250_pci.c: In function ‘pci_oxsemi_tornado_init’:
  drivers/serial/8250_pci.c:1869: error: ‘PCI_VENDOR_OXSEMI’ undeclared (first use in this function)
  drivers/serial/8250_pci.c:1869: error: (Each undeclared identifier is reported only once
  drivers/serial/8250_pci.c:1869: error: for each function it appears in.)
  ...

Dropped as crap.

		Linus

  reply	other threads:[~2008-10-20 16:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17 19:27 [PATCH 0/3] Small series of further hardware updates Alan Cox
2008-10-17 19:28 ` [PATCH 1/3] epca: Add infinite break support Alan Cox
2008-10-17 19:28 ` [PATCH 2/3] 8250: Oxford Semiconductor Devices Alan Cox
2008-10-20 16:46   ` Linus Torvalds [this message]
2008-11-12  7:33   ` Andrey Panin
2008-11-13  7:07   ` Andrey Panin
2008-11-13  9:59     ` Alan Cox
2008-11-13 15:48     ` Linus Torvalds
2008-10-17 19:29 ` [PATCH 3/3] 8250: Add more OxSemi devices Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0810200944490.3518@nehalem.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®