From: Linus Torvalds <torvalds@linux-foundation.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andi Kleen <ak@suse.de>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Arjan van de Ven <arjan@infradead.org>,
Hugh Dickins <hugh@veritas.com>, walt <w41ter@gmail.com>
Subject: Re: [PULL] module, param and stop_machine patches
Date: Sat, 25 Oct 2008 15:33:43 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0810251529240.3327@nehalem.linux-foundation.org> (raw)
In-Reply-To: <200810260924.09479.rusty@rustcorp.com.au>
On Sun, 26 Oct 2008, Rusty Russell wrote:
>
> Thanks, Heiko tracked this down; he's probably sleeping now but Hugh and Walt
> reported this fixes it for them and it makes sense.
I'm not seeing any "tracked it down".
Yes, it moves it back to its old place, but doesn't say why the new one
didn't work.
And it then mixes things up with 'stop_machine_init()' mess. Why does that
need to run so early?
Is there any reason why the real patch isn't just to make
'stop_machine_init' a 'core_initcall()' instead of 'early_initcall()'?
IOW, I don't think that patch is anything but a "hey, test if it works
with this". None of the changes or the problems are explained. Nor do I
see a sign-off from Heiko on it.
I also don't want to see more BUG_ON()'s there. Make them warnings or
something.
Linus
next prev parent reply other threads:[~2008-10-25 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 23:05 Rusty Russell
2008-10-25 21:17 ` Linus Torvalds
2008-10-25 22:24 ` Rusty Russell
2008-10-25 22:33 ` Linus Torvalds [this message]
2008-10-25 22:56 ` Linus Torvalds
2008-10-25 23:08 ` Linus Torvalds
2008-10-26 3:11 ` walt
2008-10-26 8:16 ` Rusty Russell
2008-10-26 12:42 ` Heiko Carstens
2008-10-26 16:29 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810251529240.3327@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=ak@suse.de \
--cc=arjan@infradead.org \
--cc=gregkh@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=w41ter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®