mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	"Mikko C." <mikko.cal@gmail.com>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	USB list <linux-usb@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Oleg Nesterov <oleg@tv-sign.ru>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: Bug in workqueues [was: Usb devices randomly aren't detected with 2.6.28-rc1-git1]
Date: Sun, 26 Oct 2008 11:01:11 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0810261057290.5200@nehalem.linux-foundation.org> (raw)
In-Reply-To: <200810261855.47580.rjw@sisk.pl>



On Sun, 26 Oct 2008, Rafael J. Wysocki wrote:
> > 
> > So apparently flush_workqueue() isn't working.
> 
> Let's make that more visible (adding CCs). :-)

Isn't this the same thing that was fixed by commit 
4403b406d4369a275d483ece6ddee0088cc0d592: aka 'Revert "Call 
init_workqueues before pre smp initcalls."'

The bug was that init_workqueues was called too early, causing it to have 
wrong initialization of its CPU masks, which caused various random 
problems since it wouldn't run workqueues on anything but the boot CPU.

It is hidden by various config options (eg if you enable suspend, for 
example), which is why it probably took some time for people to notice.

		Linus

  reply	other threads:[~2008-10-26 18:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4904A77C.7090805@gmail.com>
2008-10-26 17:34 ` Alan Stern
2008-10-26 17:55   ` Rafael J. Wysocki
2008-10-26 18:01     ` Linus Torvalds [this message]
2008-10-26 18:14       ` Rafael J. Wysocki
2008-10-26 18:19         ` Linus Torvalds
2008-10-26 18:28           ` Mikko C.
2008-10-26 18:36             ` Linus Torvalds
2008-10-26 19:00               ` Mikko C.
2008-10-26 19:06                 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0810261057290.5200@nehalem.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mikko.cal@gmail.com \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®