From: Linus Torvalds <torvalds@linux-foundation.org>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: merging other repos into linux-2.6
Date: Thu, 30 Oct 2008 16:28:46 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0810301619260.21084@nehalem.linux-foundation.org> (raw)
In-Reply-To: <20081030215734.GA18822@kroah.com>
On Thu, 30 Oct 2008, Greg KH wrote:
>
> But as for the 'bisectability' at one point in the merge, you will be
> adding a stand-alone driver into the kernel itself. So for anyone
> traversing down that path, all you would be building would be the driver
> itself, the whole rest of the kernel is "gone".
Right. This was exactly what happened initially in the btrfs thing. And it
was horrid.
It was horrid because it was totally unexpected for users, and causes huge
churn and confusion when trying to check out a totally different directory
layout (and git won't remove the old *.o files, so trust me, it _will_ be
confusing).
But it was horrid also because if you do it the straightforward but stupid
way (the way that git definitely does support) by using a "subdirectory
merge" to merge the individual driver into a new location, it also makes
the history almost totally useless. Suddenly trivial things like
git log drivers/xyz/file.c
don't work well at all any more, because in the old history it will all be
under the pathname "file.c" _without_ the drivers/xyz/ part. And the
merge diff will be just one huge mess..
So yes, git can do it that way, but the end result is so horrible as to be
worse than not importing the history at all!
What I got Chris Mason to do was to run
git filter-branch --index odd-script-goes-here
with that odd script looking something like:
> #!/bin/sh
> exists=$(git ls-files fs/btrfs/)
> [ -z "$exists" ] &&
> git ls-files --stage |
> awk -F '\t' '{ print "0 0000000000000000000000000000000000000000\t" $2 "\n" $1 "\tfs/btrfs/" $2 }' |
> git update-index --index-info
which basically does a directory rename in the branch (obviously, in this
case into fs/btrfs, which is not what _you_ want). That way, at least the
directory structure of the tree you merge has the same layout, and you
don't get _that_ particular directory jumping back and forth.
Chris also merged in the history at the 2.6.26 tree (I think), so that
while his original history had had just a stand-alone btrfs build, the end
result was actually *totally* bisectable. Again, you should ask him about
any other scripts he ran.
Linus
next prev parent reply other threads:[~2008-10-30 23:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 5:49 Greg KH
2008-10-30 17:17 ` Stefan Richter
2008-10-30 19:04 ` Linus Torvalds
2008-10-30 21:52 ` Dave Kleikamp
2008-10-30 23:19 ` Linus Torvalds
2008-10-30 21:57 ` Greg KH
2008-10-30 23:28 ` Linus Torvalds [this message]
2008-10-31 3:13 ` Greg KH
2008-10-31 1:34 ` J.R. Mauro
2008-10-31 1:47 ` Linus Torvalds
2008-10-31 2:38 ` J.R. Mauro
2008-10-31 3:31 ` Theodore Tso
2008-10-31 4:08 ` Kyle Moffett
2008-10-31 12:57 ` J.R. Mauro
2008-10-31 14:22 ` Kyle Moffett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810301619260.21084@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome