From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1753912AbYKQR0R@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753912AbYKQR0R (ORCPT <rfc822;w@1wt.eu>);
	Mon, 17 Nov 2008 12:26:17 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752081AbYKQR0D
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 17 Nov 2008 12:26:03 -0500
Received: from smtp1.linux-foundation.org ([140.211.169.13]:36736 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751620AbYKQR0B (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 17 Nov 2008 12:26:01 -0500
Date: Mon, 17 Nov 2008 09:25:18 -0800 (PST)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
cc: Ingo Molnar <mingo@elte.hu>, Jens Axboe <jens.axboe@oracle.com>,
       Tejun Heo <htejun@gmail.com>, Arjan van de Ven <arjan@infradead.org>,
       Hugh Dickins <hugh@veritas.com>, linux-kernel@vger.kernel.org,
       akpm@linux-foundation.org
Subject: Re: [PATCH] Fix kunmap() argument in sg_miter_stop
In-Reply-To: <4921A6BE.7000206@goop.org>
Message-ID: <alpine.LFD.2.00.0811170922000.3468@nehalem.linux-foundation.org>
References: <20081117081117.GD26778@kernel.dk> <20081117082201.GB24603@elte.hu> <20081117083022.GE26778@kernel.dk> <20081117085046.GE28786@elte.hu> <20081117085807.GF26778@kernel.dk> <20081117093425.GG26778@kernel.dk> <20081117094147.GJ28786@elte.hu>
 <20081117094551.GI26778@kernel.dk> <20081117111350.GJ26778@kernel.dk> <4921A4F3.1030309@goop.org> <20081117171005.GA25729@elte.hu> <4921A6BE.7000206@goop.org>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Mon, 17 Nov 2008, Jeremy Fitzhardinge wrote:

> Pass the struct page * to kunmap, not the vaddr of the mapping itself.
> 
> Pointed out by Jens Axboe <jens.axboe@oracle.com>
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> ---
> drivers/xen/balloon.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ===================================================================
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -120,7 +120,7 @@
> 	if (PageHighMem(page)) {
> 		void *v = kmap(page);
> 		clear_page(v);
> -		kunmap(v);
> +		kunmap(page);
> 	} else {
> 		void *v = page_address(page);
> 		clear_page(v);

Well, quite frankly, the whole thing looks like crud.

First off, 'kmap/kunmap' work on regular pages too. So if you're highmem 
aware, you should just do

	void *v = kmap(page);
	clear_page(v);
	kunmap(page);

and be done with it. 

Secondly, we actually have a function called "clear_highpage()" that does 
this, except it uses kmap_atomic(page, KM_USER0). Which is _probably 
better anyway, but I didn't check if there is some magical reason why it 
wouldn't work.

			Linus