From: Linus Torvalds <torvalds@linux-foundation.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: linux-kernel@vger.kernel.org, cebbert@redhat.com,
airlied@gmail.com, akpm@linux-foundation.org
Subject: Re: [PATCH] lib/idr.c: Fix bug introduced by RCU fix
Date: Wed, 10 Dec 2008 09:39:10 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0812100938210.3340@localhost.localdomain> (raw)
In-Reply-To: <200812101729.mBAHTGdr008642@mail.q-ag.de>
On Wed, 10 Dec 2008, Manfred Spraul wrote:
>
> The last patch to lib/idr.c caused a bug if idr_get_new_above() was
> called on an empty idr:
> Usually, nodes stay on the same layer. New layers are added to the top
> of the tree.
> The exception is idr_get_new_above() on an empty tree: In this case,
> the new root node is first added on layer 0, then moved upwards.
> p->layer was not updated.
>
> As usual: You shall never rely on the source code comments, they
> will only mislead you.
>
> Signed-off-by: Manfred Spraul <manfred@colorfullife.com>
Dave Airlie - can you get this tested and acked with the people who saw
this problem with DRI?
Linus
next prev parent reply other threads:[~2008-12-10 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 17:17 Manfred Spraul
2008-12-10 17:39 ` Linus Torvalds [this message]
2008-12-10 23:46 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0812100938210.3340@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®