From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Airlie <airlied@linux.ie>
Cc: dri-devel@lists.sf.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [git pull] drm-fixes
Date: Mon, 26 Jan 2009 10:23:39 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0901261017380.5284@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.00.0901220432480.25266@skynet.skynet.ie>
Dave,
you have some odd and slightly git usage model, which shows up in various
commits. Lookie here as an example from comit 335041ed:
Author: Jesse Barnes <jbarnes@virtuousgeek.org> 2009-01-22 04:22:06
Committer: Dave Airlie <airlied@redhat.com> 2009-01-22 04:22:06
drm/i915: hook up LVDS DPMS property
The LVDS output supports DPMS calls, but we never hooked up the property code,
so set property calls didn't actually do anything. Implement a set_property
callback for the LVDS output so that the right thing happens.
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
and this has a few issues that trigger my "Dave is doing something wrong"
reaction:
- The signed-off-chain is incomplete from the author to the committer.
A _good_ sign-off will always have the sign-offs from the author and
the committer and everybody in between. This one does not. Clearly
Jesse did sign off on his work, but he is not listed as the committer:
you are. And that means that your sign-off is missing.
- You are clearly lying about dates and/or dropping them.
The dates for authorship and committing are the same, yet the author
and committer are clearly _not_ the same. You can try to convince me
that you committed Jesse's work the same second he sent it to you, but
quite frankly, I don't buy it. End result: you've done something to
drop the date information.
I don't know what tools you use, or what process the patches go through,
but I do know that whatever your process is, it's losing information.
Please fix it.
I've pulled, but I hope I won't have to see these issues in future pull
requests.
Linus
next prev parent reply other threads:[~2009-01-26 18:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 4:46 Dave Airlie
2009-01-26 18:23 ` Linus Torvalds [this message]
2009-01-26 21:44 ` Dave Airlie
2009-01-26 21:52 ` Sam Ravnborg
2009-01-26 22:08 ` Linus Torvalds
2009-01-26 22:19 ` Linus Torvalds
2009-01-26 22:38 ` Johannes Weiner
2009-02-23 0:15 Dave Airlie
2009-02-25 4:56 Dave Airlie
2009-08-04 3:45 Dave Airlie
2009-08-05 2:11 Dave Airlie
2009-10-28 1:32 Dave Airlie
2010-09-02 1:37 Dave Airlie
2011-01-24 23:19 Dave Airlie
2011-06-17 0:38 Dave Airlie
2011-12-24 17:43 Dave Airlie
2012-06-17 7:42 Dave Airlie
2012-06-17 19:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0901261017380.5284@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sf.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®