mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@elte.hu>,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Can request_irq be called under spinlock?
Date: Fri, 13 Feb 2009 10:23:57 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.0902131022220.16972@localhost.localdomain> (raw)
In-Reply-To: <4994B23D.4040806@goop.org>

On Thu, 12 Feb 2009, Jeremy Fitzhardinge wrote:
> Thomas Gleixner wrote:
> > I dont think that proc_mkdir conventions have changed
> > recently. According to git blame fs/proc/generic.c:
> > 
> > ^1da177e (Linus Torvalds     2005-04-16 15:20:36 -0700 580)     ent =
> > kmalloc(sizeof(struct proc_dir_entry) + len + 1, GFP_KERNEL);
> > 
> >   
> 
> I think its new that request_irq ends up calling proc_mkdir though.  But its
> moot now anyway; I cleaned up that code, and don't call request_irq under
> spinlock any more.

Just checked. The register_irq_proc() and register_handler_proc()
calls in request/setup_irq() have the same time stamp in git :)

Thanks,

	tglx

      parent reply	other threads:[~2009-02-13  9:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 20:08 Jeremy Fitzhardinge
2009-02-12 22:28 ` Thomas Gleixner
2009-02-12 23:35   ` Jeremy Fitzhardinge
2009-02-13  3:38     ` Johannes Weiner
2009-02-13  9:52       ` Ingo Molnar
2009-02-13  9:23     ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0902131022220.16972@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®