From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Airlie <airlied@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Yinghai Lu <yinghai@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Arjan van de Ven <arjan@infradead.org>,
Andy Isaacson <adi@hexapodia.org>,
Maciej Rutecki <maciej.rutecki@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Eric Anholt <eric@anholt.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"lenb@kernel.org" <lenb@kernel.org>,
mjg@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
rui.zhang@intel.com
Subject: Re: [Linux 2.6.29-rc6] [drm:i915_set_status_page] *ERROR* can not ioremap virtual address for G33 hw status page
Date: Tue, 24 Feb 2009 13:59:04 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0902241354220.3111@localhost.localdomain> (raw)
In-Reply-To: <1235511845.20084.2.camel@optimus>
On Wed, 25 Feb 2009, Dave Airlie wrote:
> >
> > The other question is, why did the ioremap_wc() fail? Why doesnt
> > it fall back to UC transparently?
>
> I'm sort of worried the drivers are going to end up doing, which at
> the moment is the only option that will work.
>
> blah = ioremap_wc();
> if (!blah)
> blah = ioremap_nocache();
>
> which seems pointless so this is a good point, where is the fallback?
I agree.
We should not fail the ioremap_wc(), we should just fall back to nocache,
(possibly with a warning). In fact I thought we did exactly that, but
maybe it only happens in certain directions.
Linus
next prev parent reply other threads:[~2009-02-24 22:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 14:46 Maciej Rutecki
2009-02-23 15:22 ` Sitsofe Wheeler
2009-02-23 18:27 ` Maciej Rutecki
2009-02-23 20:02 ` Eric Anholt
2009-02-23 21:30 ` Rafael J. Wysocki
2009-02-23 21:40 ` Maciej Rutecki
2009-02-24 1:01 ` Yinghai Lu
2009-02-24 3:23 ` Andy Isaacson
2009-02-24 5:50 ` Yinghai Lu
2009-02-24 6:48 ` Andy Isaacson
2009-02-24 22:54 ` Andy Isaacson
2009-02-25 14:35 ` Zdenek Kabelac
2009-02-27 11:14 ` Maciej Rutecki
2009-02-24 19:44 ` Ingo Molnar
2009-02-24 19:48 ` Yinghai Lu
2009-02-24 21:39 ` Ingo Molnar
2009-02-24 21:44 ` Dave Airlie
2009-02-24 21:59 ` Linus Torvalds [this message]
2009-02-24 22:10 ` Pallipadi, Venkatesh
2009-02-24 6:54 ` Maciej Rutecki
2009-02-24 8:54 ` Maciej Rutecki
2009-02-24 9:01 ` Maciej Rutecki
2009-02-24 18:25 ` Yinghai Lu
2009-02-24 3:56 ` Andy Isaacson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0902241354220.3111@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=adi@hexapodia.org \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=eric@anholt.net \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=mingo@elte.hu \
--cc=mjg@redhat.com \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=venkatesh.pallipadi@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®