From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757595AbZCQRFU (ORCPT ); Tue, 17 Mar 2009 13:05:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755767AbZCQRFD (ORCPT ); Tue, 17 Mar 2009 13:05:03 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52427 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754936AbZCQRFC (ORCPT ); Tue, 17 Mar 2009 13:05:02 -0400 Date: Tue, 17 Mar 2009 10:02:09 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Alexey Dobriyan cc: linux-kernel@vger.kernel.org, r0bertz@gentoo.org, viro@ZenIV.linux.org.uk Subject: Re: [GIT] /proc/*/task getdents fixlet In-Reply-To: <20090317170023.GA2479@x200.localdomain> Message-ID: References: <20090317160638.GA2246@x200.localdomain> <20090317170023.GA2479@x200.localdomain> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Mar 2009, Alexey Dobriyan wrote: > On Tue, Mar 17, 2009 at 09:15:46AM -0700, Linus Torvalds wrote: > > > > I assume the only difference is to avoid using a "switch()" on a 64-bit > > variable, and just cast it to "unsigned long". No? > > Yes, > > + switch ((unsigned long)filp->f_pos) { Ok, I'll do just that one by hand. Linus