From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755346AbZCVRhU (ORCPT ); Sun, 22 Mar 2009 13:37:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751134AbZCVRhF (ORCPT ); Sun, 22 Mar 2009 13:37:05 -0400 Received: from www.tglx.de ([62.245.132.106]:48384 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbZCVRhE (ORCPT ); Sun, 22 Mar 2009 13:37:04 -0400 Date: Sun, 22 Mar 2009 18:35:44 +0100 (CET) From: Thomas Gleixner To: Jaswinder Singh Rajput cc: Ingo Molnar , x86 maintainers , LKML Subject: Re: [PATCH -tip] x86: cpu/cpu.h cleanup In-Reply-To: <1237709776.909.14.camel@localhost.localdomain> Message-ID: References: <1237709776.909.14.camel@localhost.localdomain> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 22 Mar 2009, Jaswinder Singh Rajput wrote: > Is it worth to move arch/x86/kernel/cpu/cpu.h data to asm/cpu.h and if > required we can also make it private like: > #ifdef __KERNEL__ > #ifndef MODULE > private data for kernel only > #endif > #endif > > By this way we move header files to include directory. Or you have some > better option. There is no option at all. The header files which are in source directories stay just where they are. They are there for a reason. Have you even looked which files include arch/x86/kernel/cpu/cpu.h ? Thanks, tglx