From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758356AbZCZXny (ORCPT ); Thu, 26 Mar 2009 19:43:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754662AbZCZXnk (ORCPT ); Thu, 26 Mar 2009 19:43:40 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52248 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753776AbZCZXnj (ORCPT ); Thu, 26 Mar 2009 19:43:39 -0400 Date: Thu, 26 Mar 2009 16:41:15 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: David Miller cc: rdreier@cisco.com, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: RDMA/nes: Fix mis-merge In-Reply-To: Message-ID: References: <20090326.152515.43533230.davem@davemloft.net> <20090326.163114.131582923.davem@davemloft.net> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Mar 2009, Linus Torvalds wrote: > > > On Thu, 26 Mar 2009, David Miller wrote: > > > > Acked-by: David S. Miller > > Can I get a sign-off from Roland too? Btw, as far as I can tell, that function had never been tested with any polling. It had a line like netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128); but that line was _before_ 'nesvnic' was actually initialized (well, it had been initialized to NULL, so it passed in some NULL-pointer-offset to that function). I moved that initialization up in the merge, but I obviously didn't test anything. So I'd suggest somebody actually test this case, because it clearly must have gotten no testing at all. Linus