From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@cs.helsinki.fi>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [GIT PULL] SLAB include file dependency fixes + kmemtrace updates
Date: Sun, 5 Apr 2009 12:56:48 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0904051251390.4023@localhost.localdomain> (raw)
In-Reply-To: <20090405193944.GA12691@elte.hu>
On Sun, 5 Apr 2009, Ingo Molnar wrote:
>
> ( Please note that i rebased the tree exactly once, shortly after it
> got finished, to make it all bisectable and reviewable: the
> perfect insight shown in the tree now was IMHO not humanly
> possible to achieve in advance.
This is actually the rigth thing to do. Rebasing is not wrong, if it is
done judiciously (and not on already-exposed stuff).
Rebasing is bad if
- you do it so late in the game that all test experience is basically
worthless
- after you've pushed out and other people have seen and depend on that
branch (and you didn't warn them)
- you do it to other peoples git commits, so that their tree (that was
the source of the commit) now has the same commit duplicated as
something else.
I wrote a posting about rebasing to Dave Airlie on dri-devel, that might
be googleable. Hmm. Here:
http://www.mail-archive.com/dri-devel@lists.sourceforge.net/msg39091.html
so rebase isn't bad, it's often a great way to fix things as you go along.
It just goes with a few basic caveats.
Linus
next prev parent reply other threads:[~2009-04-05 20:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 19:39 Ingo Molnar
2009-04-05 19:56 ` Linus Torvalds [this message]
2009-04-05 20:02 ` Linus Torvalds
2009-04-07 1:51 ` Linus Torvalds
2009-04-07 3:51 ` Linus Torvalds
2009-04-07 4:20 ` Linus Torvalds
2009-04-07 4:45 ` Linus Torvalds
2009-04-07 5:02 ` Wu Fengguang
2009-04-07 5:28 ` [patch] ramfs: add support for "mode=" mount option, fix Ingo Molnar
2009-04-07 5:55 ` Wu Fengguang
2009-04-07 6:03 ` Ingo Molnar
2009-04-07 6:16 ` [PATCH] ramfs: fix double freeing s_fs_info on failed mount Wu Fengguang
2009-04-07 6:53 ` Ingo Molnar
2009-04-07 7:05 ` Wu Fengguang
2009-04-07 6:20 ` [PATCH] ramfs: add support for "mode=" mount option, fix Ingo Molnar
2009-04-07 5:30 ` [GIT PULL] SLAB include file dependency fixes + kmemtrace updates Wu Fengguang
2009-04-07 4:58 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0904051251390.4023@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®