From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757605AbZDNRC3 (ORCPT ); Tue, 14 Apr 2009 13:02:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753535AbZDNRCR (ORCPT ); Tue, 14 Apr 2009 13:02:17 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44338 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbZDNRCQ (ORCPT ); Tue, 14 Apr 2009 13:02:16 -0400 Date: Tue, 14 Apr 2009 09:57:58 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: David Howells cc: tj@kernel.org, mingo@elte.hu, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU() In-Reply-To: <20090414161053.28145.1209.stgit@warthog.procyon.org.uk> Message-ID: References: <20090414161053.28145.1209.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Apr 2009, David Howells wrote: > > To fix this, DECLARE_PER_CPU() should simply interpose the same section > attribute as does DEFINE_PER_CPU(). However, this is made slightly more > complex by virtue of the fact that there are several variants on DEFINE, so > these need to be matched by variants of DECLARE. This needs to be fixed. We should have the DECLARE_PER_CPU() #defines next to the DEFINE_PER_CPU ones, rather than somewhere else. So moving the logic to is wrong - make it all be in so that they can be maintained together. Linus