From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Alessandro Suardi <alessandro.suardi@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.30-rc2
Date: Tue, 14 Apr 2009 19:01:56 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0904141851570.4132@localhost.localdomain> (raw)
In-Reply-To: <1239759779.2567.817.camel@ymzhang>
On Wed, 15 Apr 2009, Zhang, Yanmin wrote:
>
> There are lots of conflictions when I apply it to 2.6.29.
>
> Bleow are just some.
>
> patching file arch/arm/configs/xm_x2xx_defconfig
> Hunk #1 FAILED at 1.
> Hunk #2 succeeded at 62 (offset -1 lines).
Damn.
It patches just fine if you use "git apply".
The problem? I had enabled rename detection in my .gitconfig due to
testing a git patch, and forgotten all about it. So when I generated the
patch, it had rename detection on. And so part of the patch looks like
diff --git a/arch/arm/configs/xm_x2xx_defconfig b/arch/arm/configs/cm_x2xx_defconfig
similarity index 83%
copy from arch/arm/configs/xm_x2xx_defconfig
copy to arch/arm/configs/cm_x2xx_defconfig
index 1039f36..797b790 100644
--- a/arch/arm/configs/xm_x2xx_defconfig
+++ b/arch/arm/configs/cm_x2xx_defconfig
@@ -1,7 +1,7 @@
#
# Automatically generated make config: don't edit
-# Linux kernel version: 2.6.27-rc8
-# Sun Oct 5 11:05:36 2008
+# Linux kernel version: 2.6.29-rc2
+# Sun Feb 1 16:31:36 2009
#
CONFIG_ARM=y
...
and other parts just contain pure renames, and "patch" obviously won't
understand any of that.
My bad. I didn't mean to leave people without git out in the rain. I've
re-uploaded a fixed one that doesn't have those git features..
Alessandro - did you also do things by applying that patch? Maybe your
compile failure can be explained by the same thing, and just comes from
not noticing the patch apply failure.
Sorry about that. The fixed patch is on master.kernel.org and should be
mirroring out asap. And I've fixed my .gitconfig, and hopefully this won't
happen again.
Linus
next prev parent reply other threads:[~2009-04-15 2:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 23:48 Linus Torvalds
2009-04-15 0:22 ` Alessandro Suardi
2009-04-15 1:17 ` Linus Torvalds
2009-04-15 0:40 ` patch-2.6.30-rc2.bz2 does not apply cleanly Tetsuo Handa
2009-04-15 1:42 ` Linux 2.6.30-rc2 Zhang, Yanmin
2009-04-15 2:01 ` Linus Torvalds [this message]
2009-04-15 2:24 ` Tetsuo Handa
2009-04-15 13:26 ` Alessandro Suardi
2009-04-15 6:21 ` Brice Goglin
2009-04-15 7:33 ` yakui_zhao
2009-04-15 7:41 ` Zhang Rui
2009-04-15 7:43 ` Brice Goglin
2009-04-15 8:33 ` Linux 2.6.30-rc2: [PATCH] ARM OABI compatibility: fix build error Matthias Kaehlcke
2009-04-15 9:03 ` Russell King - ARM Linux
2009-04-15 9:12 ` Matthias Kaehlcke
2009-04-15 9:29 ` Russell King - ARM Linux
2009-04-15 9:35 ` Matthias Kaehlcke
2009-04-15 12:22 ` Linux 2.6.30-rc2 Eyal Lebedinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0904141851570.4132@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=alessandro.suardi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®